Revert "Expose values added by logback mdc instrumentation to the appender instrumentation (#14904)" #14999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ender instrumentation (open-telemetry#14904)" This reverts commit 5514595.
laurit
approved these changes
Oct 16, 2025
|
log4j 2 agent instrumentation doesn't seem to expose these either. Library instrumentations for both logback and log4j2 expose them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5514595.
cc @maxxedev
Sorry folks, I'd like to revert this before making the upcoming release, and I will re-open #14897 to discuss alternate solutions that do not impact existing users.
I believe that
otel.instrumentation.logback-appender.experimental.capture-mdc-attributes=*is a popular setting (e.g. this is the default setting in our distro), and #14904 will add redundant (and non-semantically defined) attributes to all log records for all of those users.