make nats indy-ready #15008
Merged
make nats indy-ready #15008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into indy-nats
SylvainJuge
commented
Oct 16, 2025
| ConnectionRequestInstrumentation.class.getName() + "$RequestTimeoutFutureMessageAdvice"); | ||
| } | ||
|
|
||
| public static class MessageFutureAdviceScope { |
There was a problem hiding this comment.
[for reviewer] the name here comes from the return type of the instrumented method, this helps to avoid a ridiculously long name. Also, this is used by two distinct advices which explains why it's at the same level as other advices and not a nested class.
LikeTheSalad
approved these changes
Oct 16, 2025
laurit
reviewed
Oct 17, 2025
.../io/opentelemetry/javaagent/instrumentation/nats/v2_17/ConnectionRequestInstrumentation.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031