-
Couldn't load subscription status.
- Fork 1k
Kafka connect metadata #15021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka connect metadata #15021
Changes from all commits
ccbf44c
7420536
0a0d7c8
a448101
4f48138
cbd5825
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: "This instrumentation enables messaging spans for Kafka Connect sink tasks." | ||
| semantic_conventions: | ||
| - MESSAGING_SPANS | ||
| library_link: https://kafka.apache.org/documentation/#connect |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -35,7 +35,7 @@ public final class MetaDataCollector { | |||||
|
|
||||||
| private static final String TMP_DIR = ".telemetry"; | ||||||
| private static final Pattern MODULE_PATTERN = | ||||||
| Pattern.compile("(.*?/instrumentation/.*?)(/javaagent/|/library/)"); | ||||||
| Pattern.compile("(.*?/instrumentation/.*?)(/javaagent|/library|/testing)"); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or was remove the trailing
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, with the change in the way we are now getting the path, the result is different now |
||||||
|
|
||||||
| public static void writeTelemetryToFiles( | ||||||
| String path, | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are you thinking to use the telemetry emitted from the smoke tests?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kafka connect only runs smoke tests, so this was the only way to get that telemetry. I don't think there will be too many other instrumentations this is needed for