-
Notifications
You must be signed in to change notification settings - Fork 1k
Update aws sdk2 instrumentation to follow semconv #15028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we mark this as a breaking change? With some description like:
The following attributes have been renamed to adhere to semantic conventions:
- aws.dynamodb.provisioned_throughput.read_capacity_units -> aws.dynamodb.provisioned_read_capacity (value went from long to double)
- aws.dynamodb.provisioned_throughput.write_capacity_units -> aws.dynamodb.provisioned_write_capacity (value went from long to double)
- aws.dynamodb.exclusive_start_table_name -> aws.dynamodb.exclusive_start_table
And the following attributes are no longer emitted by default, but can be enabled with the experimental flag:
- aws.queue.name
- aws.lambda.function.name
- aws.lambda.function.arn
...y/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AwsSdkRequestType.java
Outdated
Show resolved
Hide resolved
...ary/src/test/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/FieldMapperTest.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientCoreTest.java
Outdated
Show resolved
Hide resolved
I think so. Our convention is to not emit non-spec attributes by default. By that logic these attributes should have been behind the experimental flag, but apparently we messed up. In Lines 404 to 409 in e12631d
we check whether experimental flags are enabled but in Lines 216 to 219 in e12631d
request attributes are added by default, but response attributes require the experimental flag.
|
|
Resolves #14580
Update attribute names and types and enable the ones that are in spec without the experimental falg. This PR also affects some attributes that were generated without the experimental flag, but aren't in the semantic conventions such as
aws.queue.urlandaws.queue.name.