Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Oct 17, 2025

Primarily a revert of #12835

Tested locally (with the access key), producing https://develocity.opentelemetry.io/s/edhorvqb6sivo

@trask trask marked this pull request as ready for review October 17, 2025 19:19
@trask trask requested a review from a team as a code owner October 17, 2025 19:19
// ./gradlew :smoke-tests:images:servlet:buildWindowsTestImages pushMatrix -PsmokeTestServer=jetty
id("com.bmuschko.docker-remote-api") version "9.4.0" apply false
id("com.gradle.develocity") version "4.2.2"
id("com.gradle.develocity") version "4.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine, renovate will update this again anyway

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yeah, will let renovate handle it

writer.println(buildScanUri)
}
}
}
Copy link
Contributor

@laurit laurit Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block is repeated in both branches. As a follow up could try whether

develocity {
   buildScan {
      if (!gradle.startParameter.taskNames.contains("listTestsInPartition") &&
        !gradle.startParameter.taskNames.contains(":test-report:reportFlakyTests")) {
        buildScanPublished {
          File("build-scan.txt").printWriter().use { writer ->
            writer.println(buildScanUri)
          }
        }
      }
   }
}

can be moved outside the branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants