Skip to content

Fix apidiff CI verification #15066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Fix apidiff CI verification #15066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
216a8fd
Fix apidiff CI verification
trask Oct 20, 2025
70770a7
Exclude javaagent
trask Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions conventions/src/main/kotlin/otel.japicmp-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ fun findArtifact(version: String): File {
}

// generate the api diff report for any module that is stable
if (project.findProperty("otel.stable") == "true") {
if (project.findProperty("otel.stable") == "true" && project.path != ":javaagent") {
afterEvaluate {
// Only apply japicmp to projects that have a jar task (i.e. not BOMs or platforms)
tasks.findByName("jar")?.let {
Expand Down Expand Up @@ -101,8 +101,8 @@ if (project.findProperty("otel.stable") == "true") {
?: file("$rootDir/docs/apidiffs/current_vs_$baseVersionString/${base.archivesName.get()}.txt")
)
}
// have the jApiCmp task run every time the jar task is run, to make it more likely it will get used.
named("jar") {
// have the check task depend on the api comparison task, to make it more likely it will get used.
named("check") {
finalizedBy(jApiCmp)
}
}
Expand Down
Loading