Couchbase metadata updates #15088
Merged
Couchbase metadata updates #15088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation into couchbase-metadata-updates
jaydeluca
commented
Oct 21, 2025
| testClassesDirs = sourceSets.test.get().output.classesDirs | ||
| classpath = sourceSets.test.get().runtimeClasspath | ||
|
|
||
| jvmArgs("-Dotel.semconv-stability.opt-in=database") |
There was a problem hiding this comment.
i didn't think these tests were necessary since we don't own the instrumentation
laurit
reviewed
Oct 22, 2025
| type: STRING | ||
| - name: couchbase-3.4 | ||
| description: | | ||
| Couchbase instrumentation is owned by the Couchbase project for versions 3+. This instrumentation automatically configures the instrumentation provided by the Couchbase library. |
There was a problem hiding this comment.
for 3.2 the description was changed
laurit
reviewed
Oct 22, 2025
| "couchbase:couchbase-2.6:javaagent:test" | ||
| "couchbase:couchbase-2.6:javaagent:testExperimental" | ||
| "couchbase:couchbase-2.6:javaagent:testStableSemconv" | ||
| # when running 3.x tests on macOs, switch to testcontainer couchbase/server:7.6.0 |
There was a problem hiding this comment.
We can change the version of the server to whatever is more convenient.
laurit
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14096
I had omitted documenting telemetry from the shim instrumentations, but it would have come in handy with the recent issue (#14982), so seems like a good reason to include them