Skip to content

Use UnaryOperator<X> instead of Function<X, X> where it simplifies things #15101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 24, 2025
Merged

Use UnaryOperator<X> instead of Function<X, X> where it simplifies things #15101

merged 11 commits into from
Oct 24, 2025
+489 −80

Conversation

@trask
Copy link
Member

@trask trask commented Oct 22, 2025 •
edited
Loading

By using UnaryOperator instead of Function<X, X>.

Resolves #14891

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Oct 22, 2025
@trask trask force-pushed the unary-operator branch 2 times, most recently from 87e4f74 to 6c92a1d Compare October 22, 2025 22:09
@trask trask marked this pull request as ready for review October 22, 2025 22:54
@trask trask requested a review from a team as a code owner October 22, 2025 22:54
@github-actions
Copy link
Contributor

📋 Deprecation Notice

This PR has been labeled as a deprecation. Please ensure you provide the following information:

📝 Deprecation Details Required

Please add details to help users understand:

  • What is being deprecated and why
  • What should be used instead (if applicable)
  • Timeline for removal (if known)
  • Any migration guidance

📋 Checklist

  • Deprecation details added to the PR description
  • Deprecation is documented in the changelog entry for the next release
  • Consider adding deprecation warnings in code/documentation

Your deprecation notes will be included in the release notes to help users prepare for future changes.

This comment was automatically generated because the deprecation label was applied to this PR.

@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

trask
trask commented Oct 23, 2025
View reviewed changes
...6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTelemetryBuilder.java
@CanIgnoreReturnValue
@SuppressWarnings("unchecked") // safe cast from Function to UnaryOperator
public GrpcTelemetryBuilder setClientSpanNameExtractor(
Function<SpanNameExtractor<GrpcRequest>, ? extends SpanNameExtractor<? super GrpcRequest>>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to simplify these generics, similar to #12858

@laurit laurit merged commit 9d33ce3 into open-telemetry:main Oct 24, 2025
83 checks passed
@trask trask mentioned this pull request Oct 24, 2025
Open
17 tasks
@trask trask deleted the unary-operator branch October 24, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees

No one assigned

Labels

deprecation test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explore using UnaryOperator<X> instead of Function<X, X>

3 participants

@trask @laurit @jaydeluca