Disable finatra controller spans by default #15118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was working through this as part of #14096 and noticed that these controller spans aren't behind the experimental controller flag like the others.
Changelog Info:
By default, the Java agent suppresses controller spans unless enabled via the
otel.instrumentation.common.experimental.controller-telemetry.enabledsystem property. The Finatra instrumentation was not adhering to this, and has been updated to now require the configuration flag in order to enable controller spans.Set
otel.instrumentation.common.experimental.controller-telemetry.enabled=truein order to re-enable the generation of these controller spans.