[Spring starter] Make sdk bean overridable and cache env calls #15132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
zeitlinger
reviewed
Oct 24, 2025
| case "otel.exporter.otlp.logs.headers": | ||
| return Optional.of( | ||
| mergeWithOtel(otlpExporterProperties.getLogs().getHeaders(), otelSdkMap)); | ||
| case "otel.exporter.otlp.metrics.headers": |
There was a problem hiding this comment.
It looks like this is copied from somewhere - and could be extracted into a method
There was a problem hiding this comment.
i didnt see anywhere else that this is being used, but i extracted it anyway, makes things cleaner
| return or( | ||
| environment.getProperty(ConfigUtil.normalizeEnvironmentVariableKey(name), Long.class), | ||
| otelSdkProperties.getLong(name)); | ||
| return cachedLongValues |
There was a problem hiding this comment.
Looks like a generic method could be extracted to shorten this and below methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15009
Add ability for users to customize AutoConfiguredOpenTelemetrySdk, and add cache for environment config lookups.