make javaagent-tooling and testing-common indy-ready #15133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into indy-other
SylvainJuge
commented
Oct 24, 2025
Comment on lines
+88
to
+90
| assertThat(SomeClass.isInstrumented()) | ||
| .describedAs("method return value should be preserved when exception is thrown in advice") | ||
| .isFalse(); |
There was a problem hiding this comment.
[for reviewer] in the past the method return value could be modified when advice throws an unexpected exception, now that the return value is modified through the advice method return value this is no longer possible, and thus we always get the original method return value here (and this is very probably a good thing).
SylvainJuge
commented
Oct 24, 2025
Comment on lines
-13
to
15
| @Advice.OnMethodExit(suppress = Throwable.class) | ||
| public static void throwAnException(@Advice.Return(readOnly = false) boolean returnVal) { | ||
| returnVal = true; | ||
| public static boolean throwAnException() { | ||
| throw new IllegalStateException("Test Exception"); |
There was a problem hiding this comment.
[for reviewer] with the original syntax, the method return value is altered even when the advice throws an exception, this is no longer the case with this syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031