make javaagent-tooling and testing-common indy-ready #15133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into indy-other
SylvainJuge
commented
Oct 24, 2025
...ExceptionHandler/java/io/opentelemetry/javaagent/tooling/bytebuddy/ExceptionHandlerTest.java
Outdated
Show resolved
Hide resolved
SylvainJuge
commented
Oct 24, 2025
...ng/src/testExceptionHandler/java/io/opentelemetry/javaagent/tooling/bytebuddy/BadAdvice.java
Show resolved
Hide resolved
…nstrumentation into indy-other
…nstrumentation into indy-other
SylvainJuge
commented
Oct 30, 2025
Comment on lines
+72
to
+76
| @Advice.OnMethodEnter(skipOn = Advice.OnNonDefaultValue.class) | ||
| public static boolean methodEnter() { | ||
| // always skip original method body | ||
| return true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] Without this the original return value -1 is returned in the context.FieldBackedImplementationTest#removeInstanceState test, even if the exit advice that should alter the return value executes properly.
SylvainJuge
commented
Oct 30, 2025
...ng/src/testExceptionHandler/java/io/opentelemetry/javaagent/tooling/bytebuddy/BadAdvice.java
Show resolved
Hide resolved
| suppress = Throwable.class, | ||
| onThrowable = Throwable.class, | ||
| inline = false) | ||
| public static void onMethodExit(@Advice.Thrown Throwable throwable) { |
Contributor
Author
There was a problem hiding this comment.
removing unused argument and useless annotation (advice returns void)
…nstrumentation into indy-other
…nstrumentation into indy-other
laurit
reviewed
Oct 31, 2025
...ExceptionHandler/java/io/opentelemetry/javaagent/tooling/bytebuddy/ExceptionHandlerTest.java
Outdated
Show resolved
Hide resolved
…nstrumentation into indy-other
laurit
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031