Make sqlcommenter more configurable #15169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
laurit
commented
Oct 29, 2025
| }); | ||
| } | ||
|
|
||
| private static void addSqlCommenterCustomizers(ClassLoader extensionClassLoader) { |
Contributor
Author
There was a problem hiding this comment.
Based on addHttpServerResponseCustomizers that is right before this method. It supports multiple customizers but really probably works best when there is only once customizers, since since the customizers would most likely end up overwriting what the previous customizer has set.
zeitlinger
reviewed
Oct 30, 2025
.../io/opentelemetry/instrumentation/api/incubator/semconv/db/internal/SqlCommenterBuilder.java
Show resolved
Hide resolved
zeitlinger
reviewed
Oct 31, 2025
...in/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/internal/SqlCommenter.java
Show resolved
Hide resolved
zeitlinger
approved these changes
Nov 14, 2025
.../io/opentelemetry/instrumentation/api/incubator/semconv/db/internal/SqlCommenterBuilder.java
Show resolved
Hide resolved
jaydeluca
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to specify a custom propagator, allow prepending the comment instead of appending, add an experimental api that allows extensions to chose the behavior based on the connection.