Fix intellij not seeing shaded deps of testing-common #15243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
laurit
commented
Nov 7, 2025
| testImplementation("io.opentelemetry.javaagent:opentelemetry-testing-common") | ||
| } | ||
|
|
||
| testing { |
Contributor
Author
There was a problem hiding this comment.
for javaagent the same block is in
laurit
commented
Nov 7, 2025
|
|
||
| jar { | ||
| // When there are duplicates between multiple shaded dependencies, just ignore them. | ||
| duplicatesStrategy = DuplicatesStrategy.EXCLUDE |
Contributor
Author
There was a problem hiding this comment.
shouldn't be needed since we now have a single module that shades all the dependencies armeria, protobuf etc and duplicates should already be handled there
zeitlinger
approved these changes
Nov 7, 2025
trask
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intellij doesn't understand our inclusion of shaded dependencies into
testing-common. We have tried to work around this by also adding a dependency totesting:dependencies-shaded-for-testingbut this isn't done everywhere. This PR attempts to solve it by introducing a separate module that depends on bothtesting-commonandtesting:dependencies-shaded-for-testing. Dependency substitution is used to replace usages oftesting-commonwith that module.