Skip to content

feat(vertx): inject context to downstream #15285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(vertx): inject context to downstream #15285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions instrumentation/vertx/vertx-web-3.0/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ muzzle {

dependencies {
compileOnly("io.vertx:vertx-web:3.0.0")
compileOnly("io.vertx:vertx-codegen:3.0.0")
compileOnly("io.vertx:vertx-docgen:3.0.0")

// We need both version as different versions of Vert.x use different versions of Netty
testInstrumentation(project(":instrumentation:netty:netty-4.0:javaagent"))
Expand Down
19 changes: 19 additions & 0 deletions ...n/java/io/opentelemetry/javaagent/instrumentation/vertx/RoutingContextHandlerWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,16 @@

package io.opentelemetry.javaagent.instrumentation.vertx;

import io.opentelemetry.api.GlobalOpenTelemetry;
import io.opentelemetry.api.trace.Span;
import io.opentelemetry.context.Context;
import io.opentelemetry.context.Scope;
import io.opentelemetry.context.propagation.TextMapSetter;
import io.opentelemetry.instrumentation.api.instrumenter.LocalRootSpan;
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRoute;
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteSource;
import io.vertx.core.Handler;
import io.vertx.core.http.HttpServerRequest;
import io.vertx.ext.web.RoutingContext;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.UndeclaredThrowableException;
Expand All @@ -37,6 +40,7 @@ public void handle(RoutingContext context) {
route = route.substring(0, route.length() - 1);
}
HttpServerRoute.update(otelContext, HttpServerRouteSource.NESTED_CONTROLLER, route);
injectContextToDownstream(otelContext, context.request());

try (Scope ignore = RouteHolder.init(otelContext, route).makeCurrent()) {
handler.handle(context);
Expand All @@ -49,6 +53,21 @@ public void handle(RoutingContext context) {
}
}

private static void injectContextToDownstream(
Context otelContext, HttpServerRequest serverRequest) {
TextMapSetter<HttpServerRequest> setter =
Copy link
Member

@jaydeluca jaydeluca Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the typical pattern is injecting context using TextMapSetters is something that happens in a client as opposed to server instrumentation

(carrier, key, value) -> {
if (carrier != null) {
carrier.headers().set(key, value);
}
};

GlobalOpenTelemetry.get()
.getPropagators()
.getTextMapPropagator()
.inject(otelContext, serverRequest, setter);
}

private static String getRoute(Context otelContext, RoutingContext routingContext) {
String route = routingContext.currentRoute().getPath();
String existingRoute = RouteHolder.get(otelContext);
Expand Down
Loading