Skip to content

Update play gradle plugin #15326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 1 commit into from
Nov 17, 2025
Merged

Update play gradle plugin #15326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion smoke-tests/images/play/app/controllers/HomeController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

package controllers

import javax.inject.Inject
import jakarta.inject.Inject

import play.api.mvc._

Expand Down
41 changes: 16 additions & 25 deletions smoke-tests/images/play/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.gradle.jvm.toolchain.JavaLanguageVersion
import play.gradle.Language
import java.time.LocalDateTime
import java.time.format.DateTimeFormatter

Expand All @@ -6,44 +8,33 @@ plugins {
id("otel.spotless-conventions")

id("com.google.cloud.tools.jib")
// TODO (trask) this plugin doesn't support Play 2.9+, see https://github.com/gradle/playframework/issues/185
// once play 3.1 is released, we can update to https://github.com/orgs/playframework/discussions/12338
id("org.gradle.playframework") version "0.16.0"
id("org.playframework.play") version "3.1.0-M4"
Copy link
Member Author

@trask trask Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it's still a milestone release, but seems to be working for what we need)

}

val playVer = "2.8.22"
val scalaVer = "2.12"

play {
platform {
playVersion.set(playVer)
scalaVersion.set(scalaVer)
javaVersion.set(JavaVersion.VERSION_1_8)
}
injectedRoutesGenerator.set(true)
lang.set(Language.SCALA)
}

dependencies {
implementation("com.typesafe.play:play-guice_$scalaVer:$playVer")
// Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15
// TODO (trask) remove these version overrides after updating to Play 2.9
implementation("com.google.inject:guice:5.1.0")
implementation("com.google.inject.extensions:guice-assistedinject:5.1.0")
implementation("com.typesafe.play:play-logback_$scalaVer:$playVer")
implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer")
val playVersion = "3.1.0-M4"
val scalaVersion = "2.13"

implementation("org.playframework:play-guice_$scalaVersion:$playVersion")
implementation("org.playframework:play-logback_$scalaVersion:$playVersion")
implementation("org.playframework:play-filters-helpers_$scalaVersion:$playVersion")
runtimeOnly("org.playframework:play-server_$scalaVersion:$playVersion")
runtimeOnly("org.playframework:play-pekko-http-server_$scalaVersion:$playVersion")
runtimeOnly("org.apache.pekko:pekko-http_$scalaVersion:1.3.0")
}

val targetJDK = project.findProperty("targetJDK") ?: "11"
val targetJDK = (project.findProperty("targetJDK") as String?) ?: "17"
val javaLanguageVersion = targetJDK.toIntOrNull() ?: 17

val tag = findProperty("tag")
?: DateTimeFormatter.ofPattern("yyyyMMdd.HHmmSS").format(LocalDateTime.now())

java {
// this is needed to avoid jib failing with
// "Your project is using Java 17 but the base image is for Java 8"
// (it seems the jib plugins does not understand toolchains yet)
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
toolchain.languageVersion.set(JavaLanguageVersion.of(javaLanguageVersion))
}

val repo = System.getenv("GITHUB_REPOSITORY") ?: "open-telemetry/opentelemetry-java-instrumentation"
Expand Down
2 changes: 1 addition & 1 deletion smoke-tests/images/play/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# https://www.playframework.com/documentation/latest/Configuration
play.http.secret.key=agentbenchmarktest0xCAFEDEAD
play.http.secret.key=0123456789abcdeffedcba9876543210
http.port=8080
Loading