Always add trace_id and span_id attributes to servlet requests #15485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
approved these changes
Nov 28, 2025
trask
reviewed
Dec 1, 2025
| private static final boolean ADD_TRACE_ID_REQUEST_ATTRIBUTE = | ||
| AgentInstrumentationConfig.get() | ||
| .getBoolean( | ||
| "otel.instrumentation.servlet.experimental.add-trace-id-request-attribute", true); |
Member
There was a problem hiding this comment.
do you think config is needed (given that we've had this enabled in a lot of cases for a long time)?
Contributor
Author
There was a problem hiding this comment.
I was thinking that maybe we want to disable it by default in the next major release. Could also remove the config option if you think it is better that way.
Member
There was a problem hiding this comment.
that makes sense, I like the idea of disabling by default in next major release
trask
approved these changes
Dec 3, 2025
123liuziming
pushed a commit
to 123liuziming/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.