Mongo Metadata and instrumenter refactor #15500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
looks like potentially related latest dep test failure
|
jaydeluca
commented
Dec 1, 2025
instrumentation/mongo/mongo-async-3.3/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
laurit
reviewed
Dec 2, 2025
...main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoInstrumenterFactory.java
Show resolved
Hide resolved
laurit
reviewed
Dec 2, 2025
...va/io/opentelemetry/javaagent/instrumentation/mongo/v3_1/MongoInstrumentationSingletons.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Dec 2, 2025
...c/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/TracingCommandListener.java
Show resolved
Hide resolved
laurit
reviewed
Dec 2, 2025
...ng/src/main/java/io/opentelemetry/instrumentation/mongo/testing/AbstractMongoClientTest.java
Outdated
Show resolved
Hide resolved
…dep constraint, add overload for size
laurit
reviewed
Dec 3, 2025
| description: | | ||
| Enables statement sanitization for MongoDB queries. Takes precedence over otel.instrumentation.common.db-statement-sanitizer.enabled. | ||
| type: boolean | ||
| default: true |
Contributor
There was a problem hiding this comment.
it should default to the value of otel.instrumentation.common.db-statement-sanitizer.enabled but using true should be fine too
laurit
reviewed
Dec 3, 2025
...main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Dec 3, 2025
...va/io/opentelemetry/javaagent/instrumentation/mongo/v3_7/MongoInstrumentationSingletons.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Dec 3, 2025
...ng/src/main/java/io/opentelemetry/instrumentation/mongo/testing/AbstractMongoClientTest.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While enabling metric assertions, I noticed that all mongo instrumentation modules were all emitting telemetry with the
mongo-3.1scope, so I refactored the instrumenters to use a factory instead of the builder directly so that we could customize the name per module.Part of #14096