Skip to content

Conversation

@droidnxs
Copy link
Contributor

@droidnxs droidnxs commented Dec 1, 2025

Fixes #15503

  1. On JDK 11, route matcher does not capture the http.route attribute at all in some cases. As a result, the span name only encapsulates the HTTP method (e.g. GET).
  2. The span name and http.route attribute are neglecting slashes when computing the route. This is reproducible on both JDK11 and JDK21.

Following the recommendation on slack, I chose to follow a similar approach to the pekko instrumentation's route capture logic.

@droidnxs droidnxs requested a review from a team as a code owner December 1, 2025 19:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@droidnxs droidnxs force-pushed the fix-akka-http-route branch 5 times, most recently from 2032549 to 26be8a0 Compare December 2, 2025 05:53
@droidnxs droidnxs force-pushed the fix-akka-http-route branch from 26be8a0 to 1a3d820 Compare December 2, 2025 16:16
@laurit laurit added this to the v2.23.0 milestone Dec 4, 2025
@trask trask merged commit e900aee into open-telemetry:main Dec 5, 2025
111 of 163 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Dec 5, 2025

Thank you for your contribution @droidnxs! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

instrumentation/akka/akka-http-10.0 has issues populating http.route

4 participants