Disable failing rocketmq latest dep test #15512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverao
approved these changes
Dec 2, 2025
Contributor
steverao
left a comment
steverao
left a comment
There was a problem hiding this comment.
@Cirilla-zmh Could you help to debug this problem?
Member
Sure. Please assign this to me. |
123liuziming
pushed a commit
to 123liuziming/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 3, 2025
Member
|
opened #15526, if you comment on that issue then github will allow me to assign it to you |
Arunodoy18
added a commit
to Arunodoy18/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2025
Context propagation was not working correctly for batch messages in RocketMQ 5.0+ because all messages in a batch were sharing the same receive span context instead of each message having its own context extracted from message properties. Changes: - Modified ReceiveSpanFinishingCallback to extract individual context for each message in the batch using MessageMapGetter to read trace headers - Each message now gets its own properly linked context for correct tracing - Re-enabled testRocketmqProduceAndBatchConsume test for latest dependencies This fixes the issue where batch message consumers would not properly propagate trace context from producers, breaking distributed tracing for RocketMQ batch message processing in versions 5.3.4+. Resolves the disabled test from open-telemetry#15512
Arunodoy18
added a commit
to Arunodoy18/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 6, 2025
Context propagation was not working correctly for batch messages in RocketMQ 5.0+ because all messages in a batch were sharing the same receive span context instead of each message having its own context extracted from message properties. Changes: - Modified ReceiveSpanFinishingCallback to extract individual context for each message in the batch using MessageMapGetter to read trace headers - Each message now gets its own properly linked context for correct tracing - Re-enabled testRocketmqProduceAndBatchConsume test for latest dependencies This fixes the issue where batch message consumers would not properly propagate trace context from producers, breaking distributed tracing for RocketMQ batch message processing in versions 5.3.4+. Resolves the disabled test from open-telemetry#15512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context propagation doesn't seem to work with
rocketmq-client:5.3.4for batch messages. @aaron-ai @steverao if you care about this you are welcome to debug it and work with the rocketmq community if this turns out to be a bug in the rocketmq client.