Skip to content

Change breaking change checklist #15573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 3 commits into from
Dec 8, 2025
Merged

Change breaking change checklist #15573

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0688144
change wording
jaydeluca Dec 8, 2025
729b5e0
Merge branch 'main' of github.com:jaydeluca/opentelemetry-java-instru…
jaydeluca Dec 8, 2025
4858d6a
add back escaping
jaydeluca Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pr-automation-comments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ jobs:
"- Code examples showing before/after usage",
"",
"### Checklist",
"- [ ] Migration notes added to the PR description",
"- [ ] Breaking change is documented in the \"Unreleased\" section of the [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md), preferably as part of this PR.",
"- [ ] Consider if this change requires a major version bump",
"- Migration notes added to the PR description",
"- Breaking change is documented in the "Unreleased" section of the [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md), preferably as part of this PR.",
Copy link
Member

@trask trask Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need the quote escaping?

Copy link
Member Author

@jaydeluca jaydeluca Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad merge conflict resolution on my part, thanks!

"- Consider if this change requires a major version bump",
"",
"Your migration notes will be included in the release notes to help users upgrade smoothly. The more detailed and helpful they are, the better the user experience will be.",
"",
Expand Down
Loading