Skip to content

Improve Gradle configuration parallelism by removing evaluationDependsOn #15580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trask wants to merge 2 commits into from
Closed

Improve Gradle configuration parallelism by removing evaluationDependsOn #15580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6a1f7d
Enable parallel Gradle configuration by removing evaluationDependsOn
trask Dec 9, 2025
4cf3230
Fix BOM generation with parallel configuration
trask Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bom-alpha/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ javaPlatform {
allowDependencies()
}

// Need this since we access :dependencyManagement configurations below
evaluationDependsOn(":dependencyManagement")

dependencies {
api(platform("io.opentelemetry:opentelemetry-bom"))
api(platform("io.opentelemetry:opentelemetry-bom-alpha"))
Expand Down
3 changes: 3 additions & 0 deletions bom/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ javaPlatform {
allowDependencies()
}

// Need this since we access :dependencyManagement configurations below
evaluationDependsOn(":dependencyManagement")

dependencies {
api(platform("io.opentelemetry:opentelemetry-bom"))

Expand Down
4 changes: 3 additions & 1 deletion conventions/src/main/kotlin/otel.bom-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@ if (!project.name.startsWith("bom")) {
throw IllegalStateException("Name of BOM projects must start with 'bom'.")
}

// Force evaluation of all non-BOM subprojects so that we can filter them by plugin
// and add them as dependency constraints below
rootProject.subprojects.forEach { subproject ->
if (!subproject.name.startsWith("bom")) {
evaluationDependsOn(subproject.path)
}
}

val otelBom = extensions.create<OtelBomExtension>("otelBom")

afterEvaluate {
Expand Down Expand Up @@ -41,7 +44,6 @@ afterEvaluate {
}

// this applies version numbers to the SDK bom and SDK alpha bom which are dependencies of the instrumentation boms
evaluationDependsOn(":dependencyManagement")
val dependencyManagementConf = configurations.create("dependencyManagement") {
isCanBeConsumed = false
isCanBeResolved = false
Expand Down
1 change: 0 additions & 1 deletion conventions/src/main/kotlin/otel.java-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ afterEvaluate {
}
}

evaluationDependsOn(":dependencyManagement")
val dependencyManagementConf = configurations.create("dependencyManagement") {
isCanBeConsumed = false
isCanBeResolved = false
Expand Down
2 changes: 0 additions & 2 deletions conventions/src/main/kotlin/otel.javaagent-testing.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ plugins {
id("otel.java-conventions")
}

evaluationDependsOn(":testing:agent-for-testing")

dependencies {
annotationProcessor("com.google.auto.service:auto-service")
compileOnly("com.google.auto.service:auto-service")
Expand Down
Loading