Remove AgentInstrumentationConfig usages: AWS#15651
Closed
trask wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Remove AgentInstrumentationConfig usages: AWS#15651trask wants to merge 2 commits intoopen-telemetry:mainfrom
trask wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
declarative-config/b-aws
branch
2 times, most recently
from
0726fec to
4efb7be
Compare
trask
force-pushed
the
declarative-config/b-aws
branch
from
4efb7be to
9fe722b
Compare
trask
force-pushed
the
declarative-config/b-aws
branch
from
ce03df6 to
7fa0ebe
Compare
trask
commented
Dec 16, 2025
Comment on lines
+57
to
62
| * | ||
| * @deprecated Use {@link #setMessagingReceiveTelemetryEnabled(boolean)} instead. | ||
| */ | ||
| @Deprecated | ||
| @CanIgnoreReturnValue | ||
| public AwsSdkTelemetryBuilder setMessagingReceiveInstrumentationEnabled( |
Member
Author
There was a problem hiding this comment.
renamed this to match the property
// instrumentation/development:
// java:
// messaging:
// receive_telemetry/development:
// enabled: false
Comment on lines
+112
to
116
| * @deprecated Use {@link #setMessagingReceiveTelemetryEnabled(boolean)} instead. | ||
| */ | ||
| @Deprecated | ||
| @CanIgnoreReturnValue | ||
| public AwsSdkTelemetryBuilder setMessagingReceiveInstrumentationEnabled( |
| } | ||
| protected abstract boolean recordIndividualHttpError(); | ||
|
|
||
| protected abstract boolean getBoolean(String name, boolean defaultValue); |
Member
Author
There was a problem hiding this comment.
there used to be this generic getBoolean function here, I've replaced it with individual getters for each of the needed configuration properties
note that this class is odd because it still supports two configuration paths:
- java agent (now via declarative configuration API)
- library (still driven by reading system properties directly)
we still need to migrate library configuration later, at which time we can unify this(!)
Member
Author
|
Closing, going to re-do with (really) minimal changes over to declarative configuration API (including not removing ExperimentalConfig and CommonConfig) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #15668