Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class TracingRequestHandler extends RequestHandler2 {
.setCaptureExperimentalSpanAttributes(
AgentInstrumentationConfig.get()
.getBoolean("otel.instrumentation.aws-sdk.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled())
.setCapturedHeaders(ExperimentalConfig.get().getMessagingHeaders())
.build()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class TracingRequestHandler extends RequestHandler2 {
.setCaptureExperimentalSpanAttributes(
ConfigPropertiesUtil.getBoolean(
"otel.instrumentation.aws-sdk.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ConfigPropertiesUtil.getBoolean(
"otel.instrumentation.messaging.experimental.receive-telemetry.enabled", false))
.setCapturedHeaders(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class AwsSdkTelemetryBuilder {

private List<String> capturedHeaders = emptyList();
private boolean captureExperimentalSpanAttributes;
private boolean messagingReceiveInstrumentationEnabled;
private boolean messagingReceiveTelemetryEnabled;

AwsSdkTelemetryBuilder(OpenTelemetry openTelemetry) {
this.openTelemetry = openTelemetry;
Expand Down Expand Up @@ -54,11 +54,26 @@ public AwsSdkTelemetryBuilder setCaptureExperimentalSpanAttributes(
*
* <p>Note that this will cause the consumer side to start a new trace, with only a span link
* connecting it to the producer trace.
*
* @deprecated Use {@link #setMessagingReceiveTelemetryEnabled(boolean)} instead.
*/
@Deprecated
@CanIgnoreReturnValue
public AwsSdkTelemetryBuilder setMessagingReceiveInstrumentationEnabled(
boolean messagingReceiveInstrumentationEnabled) {
this.messagingReceiveInstrumentationEnabled = messagingReceiveInstrumentationEnabled;
return setMessagingReceiveTelemetryEnabled(messagingReceiveInstrumentationEnabled);
}

/**
* Set whether to capture the consumer message receive telemetry in messaging instrumentation.
*
* <p>Note that this will cause the consumer side to start a new trace, with only a span link
* connecting it to the producer trace.
*/
@CanIgnoreReturnValue
public AwsSdkTelemetryBuilder setMessagingReceiveTelemetryEnabled(
boolean messagingReceiveTelemetryEnabled) {
this.messagingReceiveTelemetryEnabled = messagingReceiveTelemetryEnabled;
return this;
}

Expand All @@ -70,6 +85,6 @@ public AwsSdkTelemetry build() {
openTelemetry,
capturedHeaders,
captureExperimentalSpanAttributes,
messagingReceiveInstrumentationEnabled);
messagingReceiveTelemetryEnabled);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public AmazonSQSAsyncClientBuilder configureClient(AmazonSQSAsyncClientBuilder c
return client.withRequestHandlers(
AwsSdkTelemetry.builder(testing().getOpenTelemetry())
.setCaptureExperimentalSpanAttributes(true)
.setMessagingReceiveInstrumentationEnabled(true)
.setMessagingReceiveTelemetryEnabled(true)
.setCapturedHeaders(singletonList("Test-Message-Header"))
.build()
.newRequestHandler());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ protected List<String> getCapturedHeaders() {
}

@Override
protected boolean messagingReceiveInstrumentationEnabled() {
protected boolean messagingReceiveTelemetryEnabled() {
return ExperimentalConfig.get().messagingReceiveInstrumentationEnabled();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ protected List<String> getCapturedHeaders() {
}

@Override
protected boolean messagingReceiveInstrumentationEnabled() {
protected boolean messagingReceiveTelemetryEnabled() {
return ConfigPropertiesUtil.getBoolean(
"otel.instrumentation.messaging.experimental.receive-telemetry.enabled", false);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public final class AwsSdkTelemetryBuilder {
private boolean useMessagingPropagator;
private boolean recordIndividualHttpError;
private boolean useXrayPropagator = true;
private boolean messagingReceiveInstrumentationEnabled;
private boolean messagingReceiveTelemetryEnabled;
private boolean genaiCaptureMessageContent;

AwsSdkTelemetryBuilder(OpenTelemetry openTelemetry) {
Expand Down Expand Up @@ -108,11 +108,26 @@ AwsSdkTelemetryBuilder setUseXrayPropagator(boolean useMessagingPropagator) {
*
* <p>Note that this will cause the consumer side to start a new trace, with only a span link
* connecting it to the producer trace.
*
* @deprecated Use {@link #setMessagingReceiveTelemetryEnabled(boolean)} instead.
*/
@Deprecated
@CanIgnoreReturnValue
public AwsSdkTelemetryBuilder setMessagingReceiveInstrumentationEnabled(
boolean messagingReceiveInstrumentationEnabled) {
this.messagingReceiveInstrumentationEnabled = messagingReceiveInstrumentationEnabled;
return setMessagingReceiveTelemetryEnabled(messagingReceiveInstrumentationEnabled);
}

/**
* Set whether to capture the consumer message receive telemetry in messaging instrumentation.
*
* <p>Note that this will cause the consumer side to start a new trace, with only a span link
* connecting it to the producer trace.
*/
@CanIgnoreReturnValue
public AwsSdkTelemetryBuilder setMessagingReceiveTelemetryEnabled(
boolean messagingReceiveTelemetryEnabled) {
this.messagingReceiveTelemetryEnabled = messagingReceiveTelemetryEnabled;
return this;
}

Expand All @@ -139,7 +154,7 @@ public AwsSdkTelemetry build() {
useMessagingPropagator,
useXrayPropagator,
recordIndividualHttpError,
messagingReceiveInstrumentationEnabled,
messagingReceiveTelemetryEnabled,
genaiCaptureMessageContent);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ private boolean captureExperimentalSpanAttributes() {
return getBoolean("otel.instrumentation.aws-sdk.experimental-span-attributes", false);
}

protected abstract boolean messagingReceiveInstrumentationEnabled();
protected abstract boolean messagingReceiveTelemetryEnabled();

private boolean useMessagingPropagator() {
return getBoolean(
Expand All @@ -42,7 +42,7 @@ public AwsSdkTelemetry telemetry() {
return AwsSdkTelemetry.builder(GlobalOpenTelemetry.get())
.setCapturedHeaders(getCapturedHeaders())
.setCaptureExperimentalSpanAttributes(captureExperimentalSpanAttributes())
.setMessagingReceiveInstrumentationEnabled(messagingReceiveInstrumentationEnabled())
.setMessagingReceiveTelemetryEnabled(messagingReceiveTelemetryEnabled())
.setUseConfiguredPropagatorForMessaging(useMessagingPropagator())
.setRecordIndividualHttpError(recordIndividualHttpError())
.setGenaiCaptureMessageContent(genaiCaptureMessageContent())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void setup() {
AwsSdkTelemetryBuilder telemetryBuilder =
AwsSdkTelemetry.builder(getTesting().getOpenTelemetry())
.setCaptureExperimentalSpanAttributes(true)
.setMessagingReceiveInstrumentationEnabled(true)
.setMessagingReceiveTelemetryEnabled(true)
.setCapturedHeaders(singletonList("Test-Message-Header"));

configure(telemetryBuilder);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public final class JmsSingletons {
JmsInstrumenterFactory factory =
new JmsInstrumenterFactory(GlobalOpenTelemetry.get(), INSTRUMENTATION_NAME)
.setCapturedHeaders(ExperimentalConfig.get().getMessagingHeaders())
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled());

PRODUCER_INSTRUMENTER = factory.createProducerInstrumenter();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public final class JmsSingletons {
JmsInstrumenterFactory factory =
new JmsInstrumenterFactory(GlobalOpenTelemetry.get(), INSTRUMENTATION_NAME)
.setCapturedHeaders(ExperimentalConfig.get().getMessagingHeaders())
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled());

PRODUCER_INSTRUMENTER = factory.createProducerInstrumenter();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,22 @@ public JmsInstrumenterFactory setCapturedHeaders(Collection<String> capturedHead
}

@CanIgnoreReturnValue
public JmsInstrumenterFactory setMessagingReceiveInstrumentationEnabled(
public JmsInstrumenterFactory setMessagingReceiveTelemetryEnabled(
boolean messagingReceiveInstrumentationEnabled) {
this.messagingReceiveInstrumentationEnabled = messagingReceiveInstrumentationEnabled;
return this;
}

/**
* @deprecated Use {@link #setMessagingReceiveTelemetryEnabled(boolean)} instead.
*/
@CanIgnoreReturnValue
@Deprecated
public JmsInstrumenterFactory setMessagingReceiveInstrumentationEnabled(
boolean messagingReceiveInstrumentationEnabled) {
return setMessagingReceiveTelemetryEnabled(messagingReceiveInstrumentationEnabled);
}

public Instrumenter<MessageWithDestination, Void> createProducerInstrumenter() {
JmsMessageAttributesGetter getter = JmsMessageAttributesGetter.INSTANCE;
MessageOperation operation = MessageOperation.PUBLISH;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public final class KafkaSingletons {
.setCaptureExperimentalSpanAttributes(
AgentInstrumentationConfig.get()
.getBoolean("otel.instrumentation.kafka.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled());
PRODUCER_INSTRUMENTER = instrumenterFactory.createProducerInstrumenter();
CONSUMER_RECEIVE_INSTRUMENTER = instrumenterFactory.createConsumerReceiveInstrumenter();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public KafkaTelemetry build() {
new KafkaInstrumenterFactory(openTelemetry, INSTRUMENTATION_NAME)
.setCapturedHeaders(capturedHeaders)
.setCaptureExperimentalSpanAttributes(captureExperimentalSpanAttributes)
.setMessagingReceiveInstrumentationEnabled(messagingReceiveInstrumentationEnabled);
.setMessagingReceiveTelemetryEnabled(messagingReceiveInstrumentationEnabled);

return new KafkaTelemetry(
openTelemetry,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,22 @@ public KafkaInstrumenterFactory setCaptureExperimentalSpanAttributes(
}

@CanIgnoreReturnValue
public KafkaInstrumenterFactory setMessagingReceiveInstrumentationEnabled(
public KafkaInstrumenterFactory setMessagingReceiveTelemetryEnabled(
boolean messagingReceiveInstrumentationEnabled) {
this.messagingReceiveInstrumentationEnabled = messagingReceiveInstrumentationEnabled;
return this;
}

/**
* @deprecated Use {@link #setMessagingReceiveTelemetryEnabled(boolean)} instead.
*/
@CanIgnoreReturnValue
@Deprecated
public KafkaInstrumenterFactory setMessagingReceiveInstrumentationEnabled(
boolean messagingReceiveInstrumentationEnabled) {
return setMessagingReceiveTelemetryEnabled(messagingReceiveInstrumentationEnabled);
}

public Instrumenter<KafkaProducerRequest, RecordMetadata> createProducerInstrumenter() {
return createProducerInstrumenter(Collections.emptyList());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public final class KafkaStreamsSingletons {
.setCaptureExperimentalSpanAttributes(
AgentInstrumentationConfig.get()
.getBoolean("otel.instrumentation.kafka.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled())
.createConsumerProcessInstrumenter();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class ReactorKafkaSingletons {
.setCaptureExperimentalSpanAttributes(
AgentInstrumentationConfig.get()
.getBoolean("otel.instrumentation.kafka.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled())
.createConsumerProcessInstrumenter();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ static SpringKafkaTelemetry getTelemetry(
return SpringKafkaTelemetry.builder(openTelemetryProvider.getObject())
.setCaptureExperimentalSpanAttributes(
config.getBoolean("otel.instrumentation.kafka.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
config.getBoolean(
"otel.instrumentation.messaging.experimental.receive-telemetry.enabled", false))
.setCapturedHeaders(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public final class SpringJmsSingletons {
JmsInstrumenterFactory factory =
new JmsInstrumenterFactory(GlobalOpenTelemetry.get(), INSTRUMENTATION_NAME)
.setCapturedHeaders(ExperimentalConfig.get().getMessagingHeaders())
.setMessagingReceiveInstrumentationEnabled(RECEIVE_TELEMETRY_ENABLED);
.setMessagingReceiveTelemetryEnabled(RECEIVE_TELEMETRY_ENABLED);

LISTENER_INSTRUMENTER = factory.createConsumerProcessInstrumenter(true);
RECEIVE_INSTRUMENTER = factory.createConsumerReceiveInstrumenter();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public final class SpringJmsSingletons {
JmsInstrumenterFactory factory =
new JmsInstrumenterFactory(GlobalOpenTelemetry.get(), INSTRUMENTATION_NAME)
.setCapturedHeaders(ExperimentalConfig.get().getMessagingHeaders())
.setMessagingReceiveInstrumentationEnabled(RECEIVE_TELEMETRY_ENABLED);
.setMessagingReceiveTelemetryEnabled(RECEIVE_TELEMETRY_ENABLED);

LISTENER_INSTRUMENTER = factory.createConsumerProcessInstrumenter(true);
RECEIVE_INSTRUMENTER = factory.createConsumerReceiveInstrumenter();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public final class SpringKafkaSingletons {
.setCaptureExperimentalSpanAttributes(
AgentInstrumentationConfig.get()
.getBoolean("otel.instrumentation.kafka.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled())
.build();
private static final Instrumenter<KafkaReceiveRequest, Void> BATCH_PROCESS_INSTRUMENTER;
Expand All @@ -35,7 +35,7 @@ public final class SpringKafkaSingletons {
.setCaptureExperimentalSpanAttributes(
AgentInstrumentationConfig.get()
.getBoolean("otel.instrumentation.kafka.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled())
.setErrorCauseExtractor(SpringKafkaErrorCauseExtractor.INSTANCE);
BATCH_PROCESS_INSTRUMENTER = factory.createBatchProcessInstrumenter();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,22 @@ public SpringKafkaTelemetryBuilder setCaptureExperimentalSpanAttributes(
* connecting it to the producer trace.
*/
@CanIgnoreReturnValue
public SpringKafkaTelemetryBuilder setMessagingReceiveInstrumentationEnabled(
public SpringKafkaTelemetryBuilder setMessagingReceiveTelemetryEnabled(
boolean messagingReceiveInstrumentationEnabled) {
this.messagingReceiveInstrumentationEnabled = messagingReceiveInstrumentationEnabled;
return this;
}

/**
* @deprecated Use {@link #setMessagingReceiveTelemetryEnabled(boolean)} instead.
*/
@CanIgnoreReturnValue
@Deprecated
public SpringKafkaTelemetryBuilder setMessagingReceiveInstrumentationEnabled(
boolean messagingReceiveInstrumentationEnabled) {
return setMessagingReceiveTelemetryEnabled(messagingReceiveInstrumentationEnabled);
}

/**
* Returns a new {@link SpringKafkaTelemetry} with the settings of this {@link
* SpringKafkaTelemetryBuilder}.
Expand All @@ -64,7 +74,7 @@ public SpringKafkaTelemetry build() {
new KafkaInstrumenterFactory(openTelemetry, INSTRUMENTATION_NAME)
.setCapturedHeaders(capturedHeaders)
.setCaptureExperimentalSpanAttributes(captureExperimentalSpanAttributes)
.setMessagingReceiveInstrumentationEnabled(messagingReceiveInstrumentationEnabled)
.setMessagingReceiveTelemetryEnabled(messagingReceiveInstrumentationEnabled)
.setErrorCauseExtractor(SpringKafkaErrorCauseExtractor.INSTANCE);

return new SpringKafkaTelemetry(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public final class VertxKafkaSingletons {
.setCaptureExperimentalSpanAttributes(
AgentInstrumentationConfig.get()
.getBoolean("otel.instrumentation.kafka.experimental-span-attributes", false))
.setMessagingReceiveInstrumentationEnabled(
.setMessagingReceiveTelemetryEnabled(
ExperimentalConfig.get().messagingReceiveInstrumentationEnabled());
BATCH_PROCESS_INSTRUMENTER = factory.createBatchProcessInstrumenter();
PROCESS_INSTRUMENTER = factory.createConsumerProcessInstrumenter();
Expand Down
Loading