Spring boot 4 support for RestClient #15684
Conversation
github-actions
bot
added
the
test native
instrumentation/spring/spring-boot-autoconfigure/testing/build.gradle.kts
Outdated
Show resolved
Hide resolved
|
|
||
| @Test | ||
| void restClientBuilder() { | ||
| testing.clearAllExportedData(); |
There was a problem hiding this comment.
why do you need to call clearAllExportedData here? In tests that use our InstrumentationExtension this gets automatically called before each test. If these smoke tests don't use it then perhaps it could be called from a @BeforeEach method so it wouldn't need to be called in each tests.
There was a problem hiding this comment.
one of the tests is asserting the telemetry emitted during the test setup, so BeforeEach couldn't be used, but AfterEach does
| .mutate() | ||
| .requestInterceptors( | ||
| interceptors -> { | ||
| if (interceptors.stream() |
There was a problem hiding this comment.
perhaps we should use something like in #15546 to avoid rebuilding the client when interceptor wasn't added?
There was a problem hiding this comment.
updated. depending on which PR is merged first, we can move the test to the AbstractRestClientInstrumentationAutoConfigurationTest class in the second one
…mentation into spring-restclient
jaydeluca
force-pushed
the
spring-restclient
branch
from
0901e86 to
39960c1
Compare
jaydeluca
force-pushed
the
spring-restclient
branch
from
ede1190 to
e57ab9d
Compare
...on/spring/autoconfigure/internal/instrumentation/web/RestClientBeanPostProcessorSpring4.java
Outdated
Show resolved
Hide resolved
|
|
||
| testImplementation("org.springframework:spring-test:7.0.2") | ||
| testImplementation("org.springframework.boot:spring-boot-resttestclient") | ||
| testImplementation("org.springframework.boot:spring-boot-restclient") |
There was a problem hiding this comment.
this is unrelated to the other changes, they released 4.0.1 yesterday which broke stuff. See spring-projects/spring-boot#48253
| // classes in test setup require 5.0+ | ||
| testLibrary("org.springframework.cloud:spring-cloud-starter-gateway-server-webflux:5.0.0") | ||
| testLibrary("org.springframework.boot:spring-boot-starter-test:4.0.0") | ||
| testLibrary("org.springframework.boot:spring-boot-webflux") |
There was a problem hiding this comment.
this is also unrelated to restClient but instead related to the 4.0.1 version bump overnight which resulted in some missing classes.
3 participants
Part of #14906
Addresses: #14906 (comment)