ClickHouse extract queryId attribute

[patschl]

If the client already specified a queryId attribute, it should be extracted and added as an attribute.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: patschl / name: Patrick (45563b9)

[laurit]

Usually by default we emit only telemetry that is defined in semantic conventions. Attributes that are not in semantic conventions are added only when requested by user by setting a flag like otel.instrumentation.kafka.experimental-span-attributes see

opentelemetry-java-instrumentation/instrumentation/pulsar/pulsar-2.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/telemetry/PulsarSingletons.java

Lines 146 to 149 in 2bc92d2

	if (DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "pulsar")
	.getBoolean("experimental_span_attributes/development", false)) {
	builder.addAttributesExtractor(ExperimentalProducerAttributesExtractor.INSTANCE);
	}

for an example

[patschl]

@laurit Thanks for the feedback.

I spoke to the maintainer of the clickhouse-java client, this PR might won't work after all.
Due to an upcoming change the queryId may be set after the instrumented method is invoked. If thats the case this has to be changed again anyway.

I will keep this in mind though.
Should I close this PR for now and open a new one once it's clear what needs to be done, or is it fine to leave it as a draft?

[laurit]

Should I close this PR for now and open a new one once it's clear what needs to be done, or is it fine to leave it as a draft?

I think you can close and reopen when you are ready. If something isn't available at the start of the instrumented method then you could also consider filling it at the end of the method.