Skip to content

Remove deprecated methods from HTTP library instrumentations #15802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trask merged 2 commits into from
Jan 9, 2026
Merged

Remove deprecated methods from HTTP library instrumentations #15802

trask merged 2 commits into from
Jan 9, 2026

Conversation

@trask
Copy link
Member

@trask trask commented Jan 8, 2026

In preparation for marking them stable.

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Jan 8, 2026
@trask trask mentioned this pull request Jan 8, 2026
Open
21 tasks
@trask trask force-pushed the remove-deprecated-methods branch from c64f892 to 8a03e31 Compare January 8, 2026 20:49
@trask trask marked this pull request as ready for review January 8, 2026 21:13
@trask trask requested a review from a team as a code owner January 8, 2026 21:13
steverao
steverao approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like one is missing?
https://github.com/trask/opentelemetry-java-instrumentation/blob/8a03e31b2ba4404cc7674d2c3972860cd570f2a1/instrumentation/ktor/ktor-2-common/library/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/common/AbstractKtorServerTelemetryBuilder.kt#L92-L95

@trask trask enabled auto-merge (squash) January 9, 2026 16:43
@trask trask merged commit f9fff99 into open-telemetry:main Jan 9, 2026
87 checks passed
@trask trask deleted the remove-deprecated-methods branch January 9, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

@steverao steverao steverao approved these changes

Assignees

No one assigned

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trask @laurit @steverao