Skip to content

Add classLoaderOptimization matcher #17226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 1 commit into from
Mar 30, 2026
+6 −0
Merged

Add classLoaderOptimization matcher #17226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...opentelemetry/javaagent/instrumentation/spring/rmi/v4_0/client/ClientInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
package io.opentelemetry.javaagent.instrumentation.spring.rmi.v4_0.client;

import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.extendsClass;
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.hasClassesNamed;
import static io.opentelemetry.javaagent.instrumentation.spring.rmi.v4_0.SpringRmiSingletons.clientInstrumenter;
import static net.bytebuddy.matcher.ElementMatchers.named;
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
Expand All @@ -30,6 +31,11 @@ public ElementMatcher<TypeDescription> typeMatcher() {
.or(extendsClass(named("org.springframework.ejb.access.AbstractSlsbInvokerInterceptor")));
}

@Override
public ElementMatcher<ClassLoader> classLoaderOptimization() {
return hasClassesNamed("org.springframework.ejb.access.AbstractSlsbInvokerInterceptor");
Copy link
Copy Markdown
Contributor

@SylvainJuge SylvainJuge Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason to use this class for matching ? If yes then maybe a comment would be relevant.

Copy link
Copy Markdown
Contributor Author

@laurit laurit Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is used in extendsClass(named("org.springframework.ejb.access.AbstractSlsbInvokerInterceptor")). The intent for classLoaderOptimization matchers is to allow skipping running potentially expensive matchers when the framework classes they match are not present.

}

@Override
public void transform(TypeTransformer transformer) {
transformer.applyAdviceToMethod(
Expand Down
Loading