Skip to content

Commit fb76612

Browse files
committed
fix architecture test
1 parent 3a7a05a commit fb76612

File tree

6 files changed

+10
-17
lines changed

6 files changed

+10
-17
lines changed
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,2 @@
11
Comparing source compatibility of opentelemetry-sdk-1.53.0-SNAPSHOT.jar against opentelemetry-sdk-1.52.0.jar
2-
+++ NEW INTERFACE: PUBLIC(+) ABSTRACT(+) io.opentelemetry.sdk.WithShutdown (not serializable)
3-
+++ CLASS FILE FORMAT VERSION: 52.0 <- n.a.
4-
+++ NEW INTERFACE: java.io.Closeable
5-
+++ NEW INTERFACE: java.lang.AutoCloseable
6-
+++ NEW SUPERCLASS: java.lang.Object
7-
+++ NEW METHOD: PUBLIC(+) void close()
8-
+++ NEW METHOD: PUBLIC(+) ABSTRACT(+) io.opentelemetry.sdk.common.CompletableResultCode shutdown()
2+
No changes.

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/ExtendedOpenTelemetrySdkBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
import io.opentelemetry.context.propagation.ContextPropagators;
1111
import io.opentelemetry.sdk.OpenTelemetrySdk;
1212
import io.opentelemetry.sdk.OpenTelemetrySdkBuilder;
13-
import io.opentelemetry.sdk.WithShutdown;
1413
import io.opentelemetry.sdk.extension.incubator.fileconfig.SdkConfigProvider;
1514
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
15+
import io.opentelemetry.sdk.internal.WithShutdown;
1616
import io.opentelemetry.sdk.logs.SdkLoggerProvider;
1717
import io.opentelemetry.sdk.logs.SdkLoggerProviderBuilder;
1818
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
@@ -107,7 +107,7 @@ public OpenTelemetrySdk build() {
107107
closeableConsumer.accept(tracerProvider);
108108
closeableConsumer.accept(meterProvider);
109109
closeableConsumer.accept(loggerProvider);
110-
ExtendedOpenTelemetrySdk extendedOpenTelemetrySdk =
110+
ObfuscatedExtendedOpenTelemetrySdk extendedOpenTelemetrySdk =
111111
new ObfuscatedExtendedOpenTelemetrySdk(
112112
configProvider, tracerProvider, meterProvider, loggerProvider, propagators);
113113
closeableConsumer.accept(extendedOpenTelemetrySdk);

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/ObfuscatedExtendedOpenTelemetrySdk.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,19 @@
1515
import io.opentelemetry.api.trace.TracerProvider;
1616
import io.opentelemetry.context.propagation.ContextPropagators;
1717
import io.opentelemetry.sdk.common.CompletableResultCode;
18+
import io.opentelemetry.sdk.internal.WithShutdown;
1819
import io.opentelemetry.sdk.logs.SdkLoggerProvider;
1920
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
2021
import io.opentelemetry.sdk.trace.SdkTracerProvider;
2122
import java.util.ArrayList;
2223
import java.util.List;
23-
import java.util.concurrent.TimeUnit;
2424
import java.util.concurrent.atomic.AtomicBoolean;
2525
import java.util.logging.Logger;
2626
import javax.annotation.concurrent.ThreadSafe;
2727

2828
/** The SDK implementation of {@link ExtendedOpenTelemetrySdk}. */
29-
public final class ObfuscatedExtendedOpenTelemetrySdk implements ExtendedOpenTelemetrySdk {
29+
public final class ObfuscatedExtendedOpenTelemetrySdk implements ExtendedOpenTelemetrySdk,
30+
WithShutdown {
3031

3132
private static final Logger LOGGER =
3233
Logger.getLogger(ObfuscatedExtendedOpenTelemetrySdk.class.getName());
@@ -50,6 +51,7 @@ public ObfuscatedExtendedOpenTelemetrySdk(
5051
this.propagators = propagators;
5152
}
5253

54+
@Override
5355
public CompletableResultCode shutdown() {
5456
if (!isShutdown.compareAndSet(false, true)) {
5557
LOGGER.info("Multiple shutdown calls");
@@ -62,11 +64,6 @@ public CompletableResultCode shutdown() {
6264
return CompletableResultCode.ofAll(results);
6365
}
6466

65-
@Override
66-
public void close() {
67-
shutdown().join(10, TimeUnit.SECONDS);
68-
}
69-
7067
@Override
7168
public ConfigProvider getConfigProvider() {
7269
return configProvider;

sdk/all/src/main/java/io/opentelemetry/sdk/OpenTelemetrySdk.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import io.opentelemetry.api.trace.TracerProvider;
1616
import io.opentelemetry.context.propagation.ContextPropagators;
1717
import io.opentelemetry.sdk.common.CompletableResultCode;
18+
import io.opentelemetry.sdk.internal.WithShutdown;
1819
import io.opentelemetry.sdk.logs.SdkLoggerProvider;
1920
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
2021
import io.opentelemetry.sdk.trace.SdkTracerProvider;

sdk/all/src/main/java/io/opentelemetry/sdk/OpenTelemetrySdkBuilder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import io.opentelemetry.api.GlobalOpenTelemetry;
99
import io.opentelemetry.context.propagation.ContextPropagators;
10+
import io.opentelemetry.sdk.internal.WithShutdown;
1011
import io.opentelemetry.sdk.logs.SdkLoggerProvider;
1112
import io.opentelemetry.sdk.logs.SdkLoggerProviderBuilder;
1213
import io.opentelemetry.sdk.metrics.SdkMeterProvider;

sdk/all/src/main/java/io/opentelemetry/sdk/WithShutdown.java renamed to sdk/all/src/main/java/io/opentelemetry/sdk/internal/WithShutdown.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package io.opentelemetry.sdk;
6+
package io.opentelemetry.sdk.internal;
77

88
import io.opentelemetry.sdk.common.CompletableResultCode;
99
import io.opentelemetry.sdk.logs.SdkLoggerProvider;

0 commit comments

Comments
 (0)