Restrict token permissions#7072
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Feb 7, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7072 +/- ##
=========================================
Coverage 89.84% 89.84%
Complexity 6610 6610
=========================================
Files 740 740
Lines 19981 19981
Branches 1966 1966
=========================================
Hits 17951 17951
Misses 1440 1440
Partials 590 590 ☔ View full report in Codecov by Sentry. |
jaydeluca
approved these changes
Feb 5, 2025
breedx-splk
approved these changes
Feb 6, 2025
jack-berg
reviewed
Feb 6, 2025
| jobs: | ||
| copy-images: | ||
| permissions: | ||
| contents: read |
Member
There was a problem hiding this comment.
Is this redundant?
Suggested change
| contents: read |
Member
Author
There was a problem hiding this comment.
these are needed after all: open-telemetry/opentelemetry-java-instrumentation#13247
jack-berg
reviewed
Feb 6, 2025
jack-berg
reviewed
Feb 6, 2025
jack-berg
reviewed
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at the hopefully easy ones
Related to #7068