Skip to content

Restrict token permissions #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 2 commits into from
Feb 7, 2025
Merged

Restrict token permissions #7072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f1f12b
Restrict token permissions
trask Feb 5, 2025
65a3496
Merge remote-tracking branch 'upstream/main' into token-permissions
trask Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/backport.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ on:
description: "The pull request # to backport"
required: true

permissions:
contents: read

jobs:
backport:
permissions:
contents: write # for git push to PR branch
runs-on: ubuntu-latest
steps:
- run: |
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/benchmark-tags.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,13 @@ name: Benchmark Tags
on:
workflow_dispatch:

permissions:
contents: read

jobs:
sdk-benchmark:
permissions:
contents: write # for git push to benchmarks branch
name: Benchmark SDK
runs-on: self-hosted
timeout-minutes: 10
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,13 @@ on:
branches: [ main ]
workflow_dispatch:

permissions:
contents: read

jobs:
sdk-benchmark:
permissions:
contents: write # for git push to benchmarks branch
name: Benchmark SDK
runs-on: self-hosted
timeout-minutes: 10
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/build-tracecontext-testsuite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ on:
- main
workflow_dispatch:

permissions:
contents: read

jobs:
publish:
permissions:
contents: read
packages: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/docker-test-containers-daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,14 @@ on:
- cron: "23 3 * * *"
workflow_dispatch:

permissions:
contents: read

jobs:
copy-images:
permissions:
contents: read
Copy link
Member

@jack-berg jack-berg Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this redundant?

Suggested change
contents: read

Copy link
Member Author

@trask trask Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7070 (comment)

Copy link
Member Author

@trask trask Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are needed after all: open-telemetry/opentelemetry-java-instrumentation#13247

packages: write
strategy:
matrix:
include:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/issue-management-feedback-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
issue_comment:
types: [created]

permissions:
contents: read

jobs:
issue_comment:
permissions:
contents: read
issues: write
if: >
contains(github.event.issue.labels.*.name, 'needs author feedback') &&
github.event.comment.user.login == github.event.issue.user.login
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/issue-management-stale-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,15 @@ on:
# hourly at minute 23
- cron: "23 * * * *"

permissions:
contents: read

jobs:
stale:
permissions:
contents: read
issues: write # for actions/stale to close stale issues
pull-requests: write # for actions/stale to close stale PRs
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/owasp-dependency-check-daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ name: OWASP dependency check (daily)

on:
schedule:
- cron: '30 1 * * *'
- cron: "30 1 * * *" # daily at 1:30 UTC
workflow_dispatch:

permissions:
contents: read

jobs:
analyze:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

Expand All @@ -21,6 +23,7 @@ jobs:

- name: Set up gradle
uses: gradle/actions/setup-gradle@v4

- name: Check dependencies
run: ./gradlew dependencyCheckAnalyze

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/reusable-markdown-link-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: Reusable - Markdown link check
on:
workflow_call:

permissions:
contents: read

jobs:
markdown-link-check:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/reusable-misspell-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: Reusable - Misspell check
on:
workflow_call:

permissions:
contents: read

jobs:
misspell-check:
runs-on: ubuntu-latest
Expand Down
Loading