Declarative configuration missing pieces#6677
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Sep 5, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6677 +/- ##
============================================
- Coverage 90.03% 90.02% -0.02%
- Complexity 6317 6355 +38
============================================
Files 703 703
Lines 19074 19140 +66
Branches 1869 1887 +18
============================================
+ Hits 17174 17231 +57
- Misses 1324 1334 +10
+ Partials 576 575 -1 ☔ View full report in Codecov by Sentry. |
jack-berg
changed the title
jack-berg
changed the title
jack-berg
commented
Aug 29, 2024
|
|
||
| // io.opentelemetry.sdk.extension.incubator.fileconfig | ||
| implementation("com.fasterxml.jackson.core:jackson-databind") | ||
| api("com.fasterxml.jackson.core:jackson-annotations") |
Member
Author
There was a problem hiding this comment.
Without this, open-telemetry/opentelemetry-java-contrib#1440 is full of warnings like:
/Users/jberg/.m2/repository/io/opentelemetry/opentelemetry-sdk-extension-incubator/1.42.0-alpha-SNAPSHOT/opentelemetry-sdk-extension-incubator-1.42.0-alpha-SNAPSHOT.jar(/io/opentelemetry/sdk/extension/incubator/fileconfig/internal/model/OpenTelemetryConfiguration.class): warning: Cannot find annotation method 'value()' in type 'JsonProperty'
jack-berg
commented
Aug 29, 2024
| public static StructuredConfigProperties toConfigProperties(InputStream configuration) { | ||
| Object yamlObj = loadYaml(configuration, System.getenv()); | ||
| return toConfigProperties(yamlObj); | ||
| } |
Member
Author
There was a problem hiding this comment.
This is an essential test utility, allowing you to write chunks of YAML, convert them to StructuredConfigProperties, and call ComponentProvider, i.e. https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1440/files#diff-3d0118f231281243bf34a7e7beb3809e7a6523e8ece8a17b83f1784953389ceb
jack-berg
commented
Aug 29, 2024
...java/io/opentelemetry/sdk/extension/incubator/fileconfig/YamlStructuredConfigProperties.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6574.
Little things discovered implementing open-telemetry/opentelemetry-java-contrib#1440.