#6454 log warning and adjust maxExportBatchSize when exceeds maxQueueSize.#7045
Merged
jack-berg merged 5 commits intoopen-telemetry:mainfrom Feb 25, 2025
Merged
Conversation
chukunx
force-pushed
the
help/queue-batch-size
branch
from
0744fa5 to
0f383c2
Compare
chukunx
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7045 +/- ##
============================================
+ Coverage 89.84% 89.87% +0.03%
- Complexity 6612 6624 +12
============================================
Files 740 740
Lines 19991 20008 +17
Branches 1966 1968 +2
============================================
+ Hits 17960 17983 +23
+ Misses 1439 1437 -2
+ Partials 592 588 -4 ☔ View full report in Codecov by Sentry. |
tealamore
reviewed
Feb 10, 2025
api/all/src/test/java/io/opentelemetry/api/internal/UtilsTest.java
Outdated
Show resolved
Hide resolved
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java
Show resolved
Hide resolved
sdk/trace/src/test/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorTest.java
Outdated
Show resolved
Hide resolved
jack-berg
reviewed
Feb 11, 2025
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java
Outdated
Show resolved
Hide resolved
jack-berg
approved these changes
Feb 25, 2025
trask
reviewed
Feb 26, 2025
Comment on lines
+134
to
+136
| if (maxExportBatchSize > maxQueueSize) { | ||
| logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize."); | ||
| } |
Member
There was a problem hiding this comment.
Can this generate a false positive depending on the order the setters are called?
Contributor
Author
There was a problem hiding this comment.
How about change the log level in build() to warning, remove these or use fine level here?
Member
There was a problem hiding this comment.
Sounds good to me. I think removing them from here would be ok in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6454