Promote EnvironmentResourceProvider to public API#7052
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Jan 31, 2025
Merged
Promote EnvironmentResourceProvider to public API#7052jack-berg merged 3 commits intoopen-telemetry:mainfrom
jack-berg merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (89.95%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7052 +/- ##
============================================
- Coverage 89.96% 89.84% -0.13%
+ Complexity 6664 6610 -54
============================================
Files 748 740 -8
Lines 20088 19981 -107
Branches 1970 1966 -4
============================================
- Hits 18073 17951 -122
- Misses 1423 1440 +17
+ Partials 592 590 -2 ☔ View full report in Codecov by Sentry. |
trask
approved these changes
Jan 30, 2025
...ns/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java
Outdated
Show resolved
Hide resolved
...ns/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this comment.
Users need to reference the FQCN when setting
otel.java.enabled.resource.providerandotel.java.disabled.resource.provider. Having.internal.in the package name of such a prominent resource provider isn't a good look, so let's promoteEnvironmentResourceProviderto part of the public API.