Declarative config 0.4 by jack-berg · Pull Request #7064 · open-telemetry/opentelemetry-java

jack-berg · 2025-02-03T20:11:06Z

v0.4.0 is a big release for declarative config, full of a large number of breaking changes, enhancements, and fixes as the result of applying additional scrutiny as we approach stability.

We anticipate limited churn going forward.

…y-java into schema-and-subschemas

codecov · 2025-02-03T20:17:57Z

Codecov Report

Attention: Patch coverage is 94.66667% with 24 lines in your changes missing coverage. Please review.

Project coverage is 90.02%. Comparing base (f17b8b0) to head (c97b59a).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...on/incubator/fileconfig/LoggerProviderFactory.java	80.00%	1 Missing and 4 partials ⚠️
...ion/incubator/fileconfig/MeterProviderFactory.java	84.84%	1 Missing and 4 partials ⚠️
...on/incubator/fileconfig/TracerProviderFactory.java	80.00%	1 Missing and 4 partials ⚠️
...incubator/fileconfig/CardinalityLimitsFactory.java	90.90%	1 Missing and 1 partial ⚠️
...sion/incubator/fileconfig/MetricReaderFactory.java	92.59%	1 Missing and 1 partial ⚠️
...ension/incubator/fileconfig/PropagatorFactory.java	92.00%	0 Missing and 2 partials ⚠️
...extension/incubator/fileconfig/FileConfigUtil.java	88.88%	1 Missing ⚠️
...xtension/incubator/fileconfig/ResourceFactory.java	95.23%	0 Missing and 1 partial ⚠️
...lemetry/sdk/internal/ScopeConfiguratorBuilder.java	97.22%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7064      +/-   ##
============================================
+ Coverage     89.61%   90.02%   +0.40%     
- Complexity     6858     6904      +46     
============================================
  Files           780      787       +7     
  Lines         20718    20846     +128     
  Branches       2020     2023       +3     
============================================
+ Hits          18566    18766     +200     
+ Misses         1512     1441      -71     
+ Partials        640      639       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…-java into declarative-config-0.4

…y-java into declarative-config-0.4

…-config-0.4

…y-java into declarative-config-0.4

...emetry/exporter/logging/otlp/internal/logs/OtlpStdoutLogRecordExporterComponentProvider.java

...main/java/io/opentelemetry/exporter/otlp/internal/OtlpGrpcSpanExporterComponentProvider.java

...entelemetry/sdk/extension/incubator/fileconfig/component/ResourceFirstComponentProvider.java

...telemetry/exporter/logging/otlp/internal/traces/OtlpStdoutSpanExporterComponentProvider.java

...main/java/io/opentelemetry/exporter/otlp/internal/OtlpGrpcSpanExporterComponentProvider.java

sdk/common/src/main/java/io/opentelemetry/sdk/internal/GlobUtil.java

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/CardinalityLimitsFactory.java

...r/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/MetricReaderFactory.java

...a/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactory.java

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/LogRecordExporterFactory.java

…-java into declarative-config-0.4

sdk/common/src/test/java/io/opentelemetry/sdk/internal/GlobUtilTest.java

...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/PropagatorFactory.java

...c/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/ResourceDetectorFactory.java

breedx-splk · 2025-04-17T22:37:44Z

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/TextMapPropagatorFactory.java

+    if (model.getBaggage() != null) {
+      return getPropagator(spiHelper, "baggage");
+    }
+    if (model.getB3() != null) {
+      return getPropagator(spiHelper, "b3");
+    }
+    if (model.getB3multi() != null) {
+      return getPropagator(spiHelper, "b3multi");
+    }
+    if (model.getJaeger() != null) {
+      return getPropagator(spiHelper, "jaeger");
+    }
+    if (model.getOttrace() != null) {
+      return getPropagator(spiHelper, "ottrace");
+    }


wait these can't be combined/composed? 😢

breedx-splk · 2025-04-17T22:50:46Z

.../test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/MeterProviderFactoryTest.java

-  void create_Defaults() {
+  @ParameterizedTest
+  @MethodSource("createArguments")
+  void create(MeterProviderModel model, SdkMeterProvider expectedProvider) {


using the toString() for testing seems error prone and fragile, but it's what we have right now....and anything else would understandably be quite difficult.

...c/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/MetricReaderFactoryTest.java

breedx-splk

Really surprised at the sheer volume of code required to support configuration! I wonder if we'll have this exercise with every version, or if it's mostly that this one was particularly beefy....

Anyway, thanks for taking this on!

jack-berg · 2025-04-18T14:37:09Z

Really surprised at the sheer volume of code required to support configuration! I wonder if we'll have this exercise with every version, or if it's mostly that this one was particularly beefy....

Yeah I'm a bit surprised the volume too. I think the volume / complexity of config mostly reflects the essential complexity of what otel specified requirements for SDKs up to this point. I.e. it can probably be expressed a little more concisely / simply, but not too much without being opinionated and chopping off concepts.

If we're as close to stabilizing declarative config as I think we are, this PR should be significantly larger than future PRs. The things that make for big PRs are: 1. large refactoring of the declarative config schema 2. large introduction of new declarative config schema. Both of those should be greatly reduced going forward.

jack-berg added 8 commits November 22, 2024 15:06

wip

86ce839

wip

d97bba3

Changes as of 12/4/24

5bf6a97

Refactored OTLP exporter schema

9d0c25e

changes as of 1/14/25

e016642

reflect schemas and subschemas changes

83ba41b

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

83a09a1

…y-java into schema-and-subschemas

changes as of 1/15/25

15bd160

jack-berg added 17 commits February 10, 2025 17:51

Merge banch 'main' of https://github.com/open-telemetry/opentelemetry…

4d1b409

…-java into declarative-config-0.4

Reflect changes as of 2/10

e98de18

Changes as of 03/04/2025

c972bb6

Prototype support for cardinality limits

d385f07

Changes as of 3/10/2025

611299e

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

396f02e

…y-java into declarative-config-0.4

Changes as of 3/11/2025

31af9ff

Merge branch 'declarative-config-cardinality-limits' into declarative…

7ab9b34

…-config-0.4

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

ea98d80

…y-java into declarative-config-0.4

Add support for resource detectors

6267222

Merge branch 'declarative-config-scopes' into declarative-config-0.4

36b7645

Add meter and logger scope config

e9fe818

Restore kitchen sink test

5d8165b

Add more test coverage

b124b82

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

14b362f

…y-java into declarative-config-0.4

Enable kitchen-sink.yaml test

e19e260

Use v0.4.0 tag

e5fb69a

jack-berg marked this pull request as ready for review March 31, 2025 15:55

jack-berg requested a review from a team as a code owner March 31, 2025 15:55

jack-berg changed the title ~~DRAFT: Declarative config 0.4~~ Declarative config 0.4 Mar 31, 2025

Use 0.4 file_format

c7a708a

jack-berg added 2 commits March 31, 2025 11:23

Restore werror

7f6f6ad

Trailing comma

42db913

jack-berg mentioned this pull request Apr 8, 2025

Add resource detector name open-telemetry/opentelemetry-specification#4461

Merged

breedx-splk self-requested a review April 10, 2025 16:22

zeitlinger reviewed Apr 11, 2025

View reviewed changes

breedx-splk reviewed Apr 11, 2025

View reviewed changes

...telemetry/exporter/logging/otlp/internal/traces/OtlpStdoutSpanExporterComponentProvider.java Show resolved Hide resolved

breedx-splk reviewed Apr 11, 2025

View reviewed changes

...main/java/io/opentelemetry/exporter/otlp/internal/OtlpGrpcSpanExporterComponentProvider.java Show resolved Hide resolved

breedx-splk mentioned this pull request Apr 11, 2025

Example approach of making implementations more similar jack-berg/opentelemetry-java#19

Closed

breedx-splk reviewed Apr 16, 2025

View reviewed changes

sdk/common/src/main/java/io/opentelemetry/sdk/internal/GlobUtil.java Outdated Show resolved Hide resolved

breedx-splk reviewed Apr 16, 2025

View reviewed changes

sdk/common/src/main/java/io/opentelemetry/sdk/internal/GlobUtil.java Outdated Show resolved Hide resolved

breedx-splk reviewed Apr 16, 2025

View reviewed changes

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/CardinalityLimitsFactory.java Show resolved Hide resolved

breedx-splk reviewed Apr 16, 2025

View reviewed changes

...r/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/MetricReaderFactory.java Show resolved Hide resolved

breedx-splk reviewed Apr 16, 2025

View reviewed changes

...a/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactory.java Outdated Show resolved Hide resolved

breedx-splk reviewed Apr 16, 2025

View reviewed changes

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/LogRecordExporterFactory.java Outdated Show resolved Hide resolved

jack-berg added 3 commits April 17, 2025 10:21

erge branch 'main' of https://github.com/open-telemetry/opentelemetry…

8b3402b

…-java into declarative-config-0.4

PR feedback

8867113

rename vars

35ce0dd