Fix OWASP dependency check workflow#7115
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Feb 19, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7115 +/- ##
=========================================
Coverage 89.87% 89.87%
Complexity 6614 6614
=========================================
Files 740 740
Lines 19991 19991
Branches 1966 1966
=========================================
Hits 17966 17966
Misses 1436 1436
Partials 589 589 ☔ View full report in Codecov by Sentry. |
Member
Done |
trask
commented
Feb 18, 2025
Comment on lines
+101
to
+103
| - `NVD_API_KEY` - stored in OpenTelemetry-Java 1Password | ||
| - Generated at https://nvd.nist.gov/developers/request-an-api-key | ||
| - Key is associated with [@trask](https://github.com/trask)'s gmail address |
Member
Author
There was a problem hiding this comment.
I added the secret to this repo already
jkwatson
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7075
Please merge #7095 first, I'll need to rebase this and resolve a merge conflict between the two afterwards.