6195: Creation of DelegatingMetricData class#7159
Closed
vasantteja wants to merge 10 commits intoopen-telemetry:mainfrom
Closed
6195: Creation of DelegatingMetricData class#7159vasantteja wants to merge 10 commits intoopen-telemetry:mainfrom
vasantteja wants to merge 10 commits intoopen-telemetry:mainfrom
Conversation
… DelegatingMetricData class comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7159 +/- ##
============================================
- Coverage 89.85% 89.81% -0.05%
- Complexity 6613 6643 +30
============================================
Files 740 756 +16
Lines 19991 20079 +88
Branches 1966 1976 +10
============================================
+ Hits 17963 18033 +70
- Misses 1439 1455 +16
- Partials 589 591 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Change
Context
This PR tries to solve this ticket. I preserved the original PR that was initially raised to add this class but I added a couple other enhancements that were mentioned in the PR. @jack-berg proposed two approaches for exposing other
PointDatainterfaces:I went with the second approach because it keeps the API simpler, consistent and avoids code duplication..
Implementation Example
Finally I am thinking people might be using this class with Metric Exporter as below: