Skip to content

fix(deps): update dependency io.opentelemetry.proto:opentelemetry-proto to v1.7.0-alpha#7362

Merged
jack-berg merged 2 commits intomainfrom
renovate/io.opentelemetry.proto-opentelemetry-proto-1.x
Jun 5, 2025
Merged

fix(deps): update dependency io.opentelemetry.proto:opentelemetry-proto to v1.7.0-alpha#7362
jack-berg merged 2 commits intomainfrom
renovate/io.opentelemetry.proto-opentelemetry-proto-1.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented May 21, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.opentelemetry.proto:opentelemetry-proto 1.5.0-alpha -> 1.7.0-alpha age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner May 21, 2025 23:47
@jack-berg
Copy link
Copy Markdown
Member

cc @jhalliday - let me know what you think of the changes I made to the profile serialization logic to reflect the changes

*/
public static ProfilesRequestMarshaler create(Collection<ProfileData> profileList) {
return new ProfilesRequestMarshaler(ResourceProfilesMarshaler.create(profileList));
// Verify all profiles in batch have identical dictionary
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting.. The shared lookup tables were promoted from the profile level to the ExportProfilesServiceRequest.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (cc7d085) to head (86ed823).
Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7362      +/-   ##
============================================
- Coverage     89.87%   89.83%   -0.04%     
+ Complexity     6899     6895       -4     
============================================
  Files           786      786              
  Lines         20793    20793              
  Branches       2026     2026              
============================================
- Hits          18687    18679       -8     
- Misses         1465     1469       +4     
- Partials        641      645       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Jun 3, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jhalliday
Copy link
Copy Markdown
Contributor

@jack-berg ahh, you've been busy whilst I've been on vacation. I did have some time earmarked for this later in the week after I get caught up. Looks like I owe you a beer instead.
This is a fairly tedious mechanical cut/paste exercise to shift some fields to a new class. The spec change is driven by the use cases where 'each resource represents a cgroup and sharing the data between resources via the lookup tables is important to save in-memory and wire space', especially with host-wide eBPF system profiling. see open-telemetry/opentelemetry-proto#644 for background. I kinda like the separation of concerns regardless - ProfileData was unwieldy large. LGTM.

@jack-berg jack-berg merged commit 93d9e72 into main Jun 5, 2025
29 checks passed
@jack-berg jack-berg deleted the renovate/io.opentelemetry.proto-opentelemetry-proto-1.x branch June 5, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants