-
Notifications
You must be signed in to change notification settings - Fork 902
Implement semconv span processor health metrics #7441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7441 +/- ##
============================================
- Coverage 89.77% 89.76% -0.02%
- Complexity 6994 7032 +38
============================================
Files 798 802 +4
Lines 21200 21335 +135
Branches 2058 2070 +12
============================================
+ Hits 19033 19152 +119
- Misses 1503 1511 +8
- Partials 664 672 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - there are merge conflicts though
I'd like to wait with this one until #7430 is approved. Pretty sure there will be review remarks which also apply to this one. |
Implements the new semantic conventions SDK health metrics for span processors:
otel.sdk.processor.span.processed
for both theSimpleSpanProcessor
andBatchingSpanProcessor
otel.sdk.processor.span.queue.size
forBatchingSpanProcessor
otel.sdk.processor.span.queue.capacity
forBatchingSpanProcessor
The metrics are opt-in at the moment and can be enabled via the builders of the processors.
Support for the legacy metrics exposed by the
BatchingSpanProcessor
is kept. Those are disabled by default too (defaultMeterProvider
is noop) and can be enabled using the same API usage as before (= by providing aMeterProvider
).