don't call old plugin when declarative config is in use

[zeitlinger]

Fixes #7469

Adds a dedicated SPI to load a declarative config for a distro:

public interface DeclarativeConfigurationProvider {
  /**
   * Returns an OpenTelemetry configuration model to be used when configuring the SDK, or {@code
   * null} if no configuration is provided by this provider.
   */
  @Nullable
  OpenTelemetryConfigurationModel getConfigurationModel();
}

The added test illustrates how to use the SPI:

public class TestDeclarativeConfigurationProvider implements DeclarativeConfigurationProvider {
  @Override
  public OpenTelemetryConfigurationModel getConfigurationModel() {
    String yaml =
        "file_format: \"1.0-rc.1\"\n"
            + "resource:\n"
            + "  attributes:\n"
            + "    - name: service.name\n"
            + "      value: test\n"
            + "tracer_provider:\n"
            + "  processors:\n"
            + "    - simple:\n"
            + "        exporter:\n"
            + "          console: {}\n";

    return DeclarativeConfiguration.parse(
        new ByteArrayInputStream(yaml.getBytes(StandardCharsets.UTF_8)));
  }
}

[codecov]

Codecov Report

❌ Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.99%. Comparing base (63d4617) to head (07c61ef).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
...pentelemetry/sdk/autoconfigure/IncubatingUtil.java	88.88%	3 Missing and 1 partial ⚠️
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java	93.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #7472   +/-   ##
=========================================
  Coverage     89.99%   89.99%           
- Complexity     7079     7086    +7     
=========================================
  Files           803      803           
  Lines         21412    21434   +22     
  Branches       2086     2090    +4     
=========================================
+ Hits          19269    19290   +21     
+ Misses         1479     1478    -1     
- Partials        664      666    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zeitlinger]

@jack-berg please have a look 😄

[zeitlinger]

@jkwatson please have a look

[jkwatson]

This seems ok to me, but I don't have the background on the issue, and it seemed like Jack had some hesitation on the original issue. I don't see that resolved in that discussion. Was there a resolution that wasn't communicated in the discussion there?

[zeitlinger]

This seems ok to me, but I don't have the background on the issue, and it seemed like Jack had some hesitation on the original issue. I don't see that resolved in that discussion. Was there a resolution that wasn't communicated in the discussion there?

you're right - I missed that. I'll have to think about it again.

[zeitlinger]

This seems ok to me, but I don't have the background on the issue, and it seemed like Jack had some hesitation on the original issue. I don't see that resolved in that discussion. Was there a resolution that wasn't communicated in the discussion there?

you're right - I missed that. I'll have to think about it again.

@jkwatson now I added a new interface to address the distro use case

[jkwatson]

most (all?) of these are runtime exceptions, yeah? I don't think we usually declare them to be thrown, especially not on private methods.

[zeitlinger]

none of them are runtime exceptions

[jkwatson]

ugh, really? Sometimes Java APIs are the worst. 😂

[zeitlinger]

yes...

[jkwatson]

Thanks!

[zeitlinger]

thanks @jkwatson - really appreciate the time you're taking!