Implement random trace flag from W3C TC v2 #7521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to go ahead and close this for now as there is still not clear spec guidance on this. Can resurrect it if that changes, but hopefully it doesn't :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am helping with probability samping and one topic is the newly proposed random trace flag. I couldn't find any related issue but let me know if I missed it.
https://www.w3.org/TR/trace-context-2/#trace-flags
There is an OTel issue fishing for implementations
open-telemetry/opentelemetry-specification#3411
So I thought I would see what it could look like, extending the
IdGeneratorinterface. I suspect it would look something like this - so I am happy to close this for now and discuss on an issue instead if that will be easier as I suspect this is a relatively nuanced topic. One of the bigger ones is if this behavior gets automatically applied to all current users as this PR proposes.Personally, I think it's a reasonable option for the OTel community to band together to reject this draft. I doubt anyone working in observability has ever seen a trace ID that doesn't match the randomness requirement, and I suspect almost all apps to treat both values of
1and0as random to support older SDKs, so the value add of this flag seems mostly zero.