Skip to content

Conversation

the-clam
Copy link
Contributor

@the-clam the-clam commented Aug 12, 2025

New PR; accidentally discarded the commits for the branch used for the old PR: #7540

modified OtlpConfigUtil.java to take in:

otel.exporter.otlp.lograte
otel.exporter.otlp.throttledlograte
otel.exporter.otlp.logtimeunit

and configure the necessary values to set the log rate and throttled log rate for ThrottlingLogger.Java

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 89.01099% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.99%. Comparing base (b2c476c) to head (40718db).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...telemetry/exporter/internal/grpc/GrpcExporter.java 28.57% 5 Missing ⚠️
...telemetry/exporter/internal/http/HttpExporter.java 28.57% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7562      +/-   ##
============================================
- Coverage     90.02%   89.99%   -0.03%     
- Complexity     7080     7097      +17     
============================================
  Files           803      803              
  Lines         21417    21500      +83     
  Branches       2086     2087       +1     
============================================
+ Hits          19280    19349      +69     
- Misses         1475     1489      +14     
  Partials        662      662              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fmhwong
Copy link

fmhwong commented Aug 12, 2025

Since the new configurations are for logs, would it be better under otel.exporter.otlp.logs.*?

@the-clam
Copy link
Contributor Author

Since the new configurations are for logs, would it be better under otel.exporter.otlp.logs.*?

Will wait for the others to get back to me before I make changes for that, comments were left in an older PR that wasn't working properly: #7540 (comment)

@the-clam the-clam marked this pull request as ready for review August 20, 2025 19:16
@the-clam the-clam requested a review from a team as a code owner August 20, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants