Fix TraceState key validation limits to match W3C spec #7575
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7575 +/- ##
============================================
- Coverage 90.01% 90.00% -0.01%
Complexity 7080 7080
============================================
Files 803 803
Lines 21417 21417
Branches 2086 2086
============================================
- Hits 19278 19276 -2
- Misses 1477 1478 +1
- Partials 662 663 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zeitlinger
reviewed
Aug 18, 2025
| void testVendorIdLongerThan13Characters() { | ||
| assertThat(TraceState.builder().put("1@nrabcdefghijkl", FIRST_VALUE).build()) | ||
| void testVendorIdWith14Characters() { | ||
| String key = "1@nrabcdefghijkl"; |
There was a problem hiding this comment.
Multi-tenant keys are formed with: a tenant-id, the "@" symbol, and a system-id (called vendor-id in the otel-java codebase).
This test verifies behavior for a system-id of 14 chars, so what follows the @ should be that long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the multi-tenant vendor key validation limits in
ArrayBasedTraceStateBuilderto properly comply with the W3C Trace Context specification.Changes:
MAX_VENDOR_ID_SIZEfrom 13 to 14 charactersMAX_TENANT_ID_SIZEfrom 240 to 241 charactersBackground
The current implementation incorrectly rejects valid keys according to the W3C Trace Context specification. The rules define:
This means:
tenant-id: 1 + 240 = 241 characters maximumsystem-id: 1 + 13 = 14 characters maximum