Skip to content

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Sep 4, 2025

Alternative to #7418 that

  • does not expose resource more than it already is - as part of AutoConfiguredOpenTelemetrySdk
  • does not create resource twice

Fixes open-telemetry/opentelemetry-java-instrumentation#14325

@zeitlinger zeitlinger requested a review from a team as a code owner September 4, 2025 11:00
@zeitlinger zeitlinger self-assigned this Sep 4, 2025
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (89c7973) to head (1079cdc).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7639      +/-   ##
============================================
+ Coverage     90.13%   90.16%   +0.03%     
- Complexity     7192     7195       +3     
============================================
  Files           814      814              
  Lines         21713    21719       +6     
  Branches       2127     2125       -2     
============================================
+ Hits          19570    19583      +13     
+ Misses         1477     1471       -6     
+ Partials        666      665       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments but I think this is a decent way to proceed.

@zeitlinger zeitlinger force-pushed the declarative-config-return-resource branch from 5f388fb to 16e1492 Compare September 25, 2025 12:15
@zeitlinger
Copy link
Member Author

@jack-berg please check again

Copy link
Contributor

@robsunday robsunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution works perfectly and I can access resource attributes in my BeforeAgentListener implementations

@zeitlinger
Copy link
Member Author

@jack-berg can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declarative config: extract Resource correctly
3 participants