-
Notifications
You must be signed in to change notification settings - Fork 909
return resource in auto configured sdk #7639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
return resource in auto configured sdk #7639
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7639 +/- ##
============================================
+ Coverage 90.13% 90.16% +0.03%
- Complexity 7192 7195 +3
============================================
Files 814 814
Lines 21713 21719 +6
Branches 2127 2125 -2
============================================
+ Hits 19570 19583 +13
+ Misses 1477 1471 -6
+ Partials 666 665 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1b36c6e
to
5f388fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments but I think this is a decent way to proceed.
...xtensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/IncubatingUtil.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/sdk/extension/incubator/fileconfig/AutoConfiguredOpenTelemetrySdkAccess.java
Outdated
Show resolved
Hide resolved
5f388fb
to
16e1492
Compare
@jack-berg please check again |
.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution works perfectly and I can access resource attributes in my BeforeAgentListener
implementations
.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java
Show resolved
Hide resolved
@jack-berg can this be merged? |
Alternative to #7418 that
AutoConfiguredOpenTelemetrySdk
Fixes open-telemetry/opentelemetry-java-instrumentation#14325