Skip to content

Conversation

trask
Copy link
Member

@trask trask commented Sep 23, 2025

I have a couple of PRs where this would be helpful.

Initially I combined it into the existing benchmark.yml but it just ended up being if conditions everywhere, so prefer them separate in the end.

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (f3c8886) to head (c3e1f60).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7698   +/-   ##
=========================================
  Coverage     90.12%   90.12%           
  Complexity     7187     7187           
=========================================
  Files           814      814           
  Lines         21700    21700           
  Branches       2123     2123           
=========================================
  Hits          19557    19557           
  Misses         1477     1477           
  Partials        666      666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask trask force-pushed the run-benchmarks-on-prs branch 9 times, most recently from b874977 to 85c591c Compare September 23, 2025 21:41
contents: read

env:
BENCHMARK_CLASSES: SpanBenchmark SpanPipelineBenchmark ExporterBenchmark
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the list from

java -jar libs/opentelemetry-sdk-trace-*-jmh.jar -rf json SpanBenchmark SpanPipelineBenchmark ExporterBenchmark

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the third benchmark workflow

would it be possible to use the "reusable pattern" or alternatively use a script?

@trask trask marked this pull request as ready for review September 23, 2025 22:46
@trask trask requested a review from a team as a code owner September 23, 2025 22:46
@trask trask force-pushed the run-benchmarks-on-prs branch from 85c591c to c3e1f60 Compare September 24, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants