Skip to content

Conversation

trask
Copy link
Member

@trask trask commented Sep 25, 2025

@trask trask requested a review from a team as a code owner September 25, 2025 02:12
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (1e763b2) to head (fe84c31).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7706      +/-   ##
============================================
+ Coverage     90.12%   90.15%   +0.02%     
- Complexity     7187     7189       +2     
============================================
  Files           814      814              
  Lines         21700    21702       +2     
  Branches       2123     2125       +2     
============================================
+ Hits          19557    19565       +8     
+ Misses         1477     1472       -5     
+ Partials        666      665       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm fine with this change.

@jack-berg
Copy link
Member

Can we discuss this before merging? #7700 (comment)

Thanks!

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make this to relevant places for SdkTracer, SdkMeter (and MetricStorage impls), but I'm happy with now that I see that it only adds ~.8ns / operation

Copilot AI and others added 2 commits September 29, 2025 21:08
…-10ae5da2915a

Make enabled fields volatile in SdkTracer, SdkMeter, and MetricStorage implementations
@trask
Copy link
Member Author

trask commented Sep 29, 2025

Should make this to relevant places for SdkTracer, SdkMeter (and MetricStorage impls), but I'm happy with now that I see that it only adds ~.8ns / operation

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants