-
Notifications
You must be signed in to change notification settings - Fork 909
Spec update: Changes to disabled config must be eventually visible #7706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7706 +/- ##
============================================
+ Coverage 90.12% 90.15% +0.02%
- Complexity 7187 7189 +2
============================================
Files 814 814
Lines 21700 21702 +2
Branches 2123 2125 +2
============================================
+ Hits 19557 19565 +8
+ Misses 1477 1472 -5
+ Partials 666 665 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm fine with this change.
Can we discuss this before merging? #7700 (comment) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should make this to relevant places for SdkTracer, SdkMeter (and MetricStorage impls), but I'm happy with now that I see that it only adds ~.8ns / operation
…e implementations Co-authored-by: trask <[email protected]>
…-10ae5da2915a Make enabled fields volatile in SdkTracer, SdkMeter, and MetricStorage implementations
done |
Implements open-telemetry/opentelemetry-specification#4645
See benchmarks in #7700