use common link checker and fix links #7733
Open
+58
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trask same approach as agent |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7733 +/- ##
=========================================
Coverage 90.16% 90.16%
Complexity 7190 7190
=========================================
Files 814 814
Lines 21702 21702
Branches 2125 2125
=========================================
Hits 19568 19568
Misses 1467 1467
Partials 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zeitlinger
force-pushed
the
lychee-mise
branch
from
05d39bc to
e51e86f
Compare
trask
approved these changes
Oct 8, 2025
Comment on lines
+14
to
+21
| [tasks."lint:links"] | ||
| file = "https://raw.githubusercontent.com/open-telemetry/opentelemetry-java-contrib/refs/heads/main/.mise/tasks/lint/links.sh" | ||
|
|
||
| [tasks."lint:local-links"] | ||
| file = "https://raw.githubusercontent.com/open-telemetry/opentelemetry-java-contrib/refs/heads/main/.mise/tasks/lint/local-links.sh" | ||
|
|
||
| [tasks."lint:links-in-modified-files"] | ||
| file = "https://raw.githubusercontent.com/open-telemetry/opentelemetry-java-contrib/refs/heads/main/.mise/tasks/lint/links-in-modified-files.sh" |
There was a problem hiding this comment.
probably ideally these files would live in this (the "core") repo, since that's the direction most of our other dependencies flow
There was a problem hiding this comment.
maybe the spec repo if the approach proves to be successful?
Either way, we'd have to adjust all repos that pull the files before we remove it in contrib
Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.