Skip to content

Fix a few declarative configuration bugs #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 1 commit into from
Nov 2, 2025
Merged

Fix a few declarative configuration bugs #7807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ommon/src/main/java/io/opentelemetry/exporter/internal/IncubatingExporterBuilderUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public static void configureOtlpAggregationTemporality(
case "delta":
temporalitySelector = AggregationTemporalitySelector.deltaPreferred();
break;
case "lowmemory":
case "low_memory":
temporalitySelector = AggregationTemporalitySelector.lowMemory();
break;
default:
Expand Down
2 changes: 1 addition & 1 deletion .../main/java/io/opentelemetry/exporter/prometheus/internal/PrometheusComponentProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public Class<MetricReader> getType() {

@Override
public String getName() {
return "prometheus";
return "prometheus/development";
}

@Override
Expand Down
3 changes: 2 additions & 1 deletion ...rc/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/MetricReaderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ public MetricReaderAndCardinalityLimits create(
if (prometheusModel != null) {
MetricReader metricReader =
context.addCloseable(
context.loadComponent(MetricReader.class, "prometheus", prometheusModel));
context.loadComponent(
MetricReader.class, "prometheus/development", prometheusModel));
CardinalityLimitSelector cardinalityLimitSelector = null;
if (model.getCardinalityLimits() != null) {
cardinalityLimitSelector =
Expand Down
4 changes: 2 additions & 2 deletions ...est/java/io/opentelemetry/sdk/extension/incubator/fileconfig/MetricReaderFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ void create_PullPrometheusDefault() throws IOException {
assertThat(reader.toString()).isEqualTo(expectedReader.toString());
assertThat(readerAndCardinalityLimits.getCardinalityLimitsSelector()).isNull();
// TODO(jack-berg): validate prometheus component provider was invoked with correct arguments
verify(context).loadComponent(eq(MetricReader.class), eq("prometheus"), any());
verify(context).loadComponent(eq(MetricReader.class), eq("prometheus/development"), any());
}

@Test
Expand Down Expand Up @@ -204,7 +204,7 @@ void create_PullPrometheusConfigured() throws IOException {
.getCardinalityLimit(InstrumentType.COUNTER))
.isEqualTo(100);
// TODO(jack-berg): validate prometheus component provider was invoked with correct arguments
verify(context).loadComponent(eq(MetricReader.class), eq("prometheus"), any());
verify(context).loadComponent(eq(MetricReader.class), eq("prometheus/development"), any());
}

@Test
Expand Down
Loading