Skip to content

[DO NOT MERGE] Demonstrate uri resolve behavior change from java 11 to 17 #7969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jack-berg wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Demonstrate uri resolve behavior change from java 11 to 17 #7969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
075cf04
Demonstrate uri resolve behavior change from java 11 to 17
jack-berg Jan 9, 2026
e2cfc08
spot
jack-berg Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...okhttp/src/test/java/io/opentelemetry/exporter/sender/okhttp/internal/UriResolveTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/

package io.opentelemetry.exporter.sender.okhttp.internal;

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;

import java.net.URI;
import org.junit.jupiter.api.Test;

class UriResolveTest {

@Test
void resolve() {
assertThat(URI.create("http://localhost:8080").resolve("path").toString())
.isEqualTo("http://localhost:8080/path");
Copy link
Member Author

@jack-berg jack-berg Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URI.resolve behavior change!

Passes on java 17+. Fails on java 11 and lower.

Copy link
Contributor

@jkwatson jkwatson Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whu? That's a surprising change (that I imagine will break lots of applications out there!)

}
}
Loading