-
Notifications
You must be signed in to change notification settings - Fork 619
feat(koa): Adds support to ignore a span by its layer name #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
4623e18 to
47bed61
Compare
f41b872 to
a5b3a6e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
+ Coverage 89.71% 89.78% +0.06%
==========================================
Files 187 187
Lines 9097 9120 +23
Branches 1879 1886 +7
==========================================
+ Hits 8161 8188 +27
+ Misses 936 932 -4
🚀 New features to boost your workflow:
|
882914e to
57512e3
Compare
57512e3 to
d5e6c1d
Compare
d5e6c1d to
5cb51b8
Compare
8e3b4df to
fe52615
Compare
f0e8dd2 to
e2b7711
Compare
ff73355 to
1dce93d
Compare
882121f to
f7565e7
Compare
f7565e7 to
8dfc847
Compare
c2119dc to
1bc39fb
Compare
4ebd167 to
7d620ea
Compare
a4ff4a8 to
9dd90be
Compare
9dd90be to
a8f600a
Compare
a8f600a to
20aed9b
Compare
0d877ed to
887f208
Compare
e197f74 to
edbaf52
Compare
edbaf52 to
f542500
Compare
f542500 to
002a7f5
Compare
002a7f5 to
b93b68e
Compare
|
@trentm - I saw you reviewed this PR before - however this PR is targeting an unmaintained component. Are you sponsoring this feature? 🤔 If yes, please apply the |
ac13a3c to
a474f5c
Compare
2894823 to
50ed50a
Compare
50ed50a to
7f9737f
Compare
7f9737f to
ab45188
Compare
|
Thanks for your continued effort in keeping this PR up to date. That said, it’s been open for quite a while without much engagement from reviewers or clear interest from end-users. To help keep the project maintainable and avoid long-lived PRs on unmaintained components, I’m going to close this PR. We're happy to revisit this feature once a new owner for @opentelemetry/instrumentation-koa is in place. If anyone is interested in becoming a component owner, please refer to this comment for more details: #2028 (comment) |
Which problem is this PR solving?
ignoreLayersNameoption to instrumentation constructor config to allow layers to be ignored by its name.ignoreLayersTypeconfig, this new one will run after this check.Short description of the changes
KoaInstrumentationConfigwithignoreLayersNamewhich is an array ofstring(layer names):isLayerNameIgnoredto check if a layer should be ignored by the name_patchLayerto check if the layer is ignored by the config