Skip to content

Conversation

@iancward
Copy link

Which problem is this PR solving?

Short description of the changes

  • Get ECS container ID from ECS metadata. This will get the correct value whether running in ECS Fargate or ECS on EC2

@iancward iancward requested a review from a team as a code owner October 28, 2024 20:19
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 28, 2024

CLA Not Signed

Which prolbem is this PR solving?

- The AWS ECS Resource detector is munging the container ID when running
  in AWS ECS Fargate

ref: open-telemetry#2032

Short description of the changes

- Get ECS container ID from ECS metadata. This will get the correct
  value whether running in ECS Fargate or ECS on EC2
@iancward iancward force-pushed the ecs_fargate_container_id branch from ed6a61a to 5f48d6a Compare October 28, 2024 20:24
@iancward iancward changed the title fix(detector-aws) - Get ECS Container ID from metadata fix(detector-aws): Get ECS Container ID from metadata Oct 28, 2024
@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (9a20e15) to head (5f48d6a).
Report is 173 commits behind head on main.

Files with missing lines Patch % Lines
...e-detector-aws/src/detectors/AwsEcsDetectorSync.ts 71.42% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (71.42%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2509      +/-   ##
==========================================
+ Coverage   90.85%   91.88%   +1.02%     
==========================================
  Files         159       52     -107     
  Lines        7853     2636    -5217     
  Branches     1622      477    -1145     
==========================================
- Hits         7135     2422    -4713     
+ Misses        718      214     -504     
Files with missing lines Coverage Δ
...e-detector-aws/src/detectors/AwsEcsDetectorSync.ts 32.22% <71.42%> (-64.90%) ⬇️

... and 107 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jackgopack4
Copy link

this would be helpful to DataDog customers using JavaScript instrumentation; several integrations in Datadog rely on container.id

@pichlermarc
Copy link
Member

@iancward thank you for your contribution - due to organization policy, we unfortunately we cannot accept any PRs without the CLA signed (see here for instructions on how to do this).

If this is still something you're interested in fixing this, please re-open a new PR once you have signed the CLA - thanks!

@iancward
Copy link
Author

iancward commented May 19, 2025

Hi @pichlermarc, apologies, the EasyCLA process is new for my company and it's taking significantly longer than expected to find the right folks to handle the paperwork, even though our legal team has signed off on the CCLA.

I'll open a new PR once this is is taken care of. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants